opendev/gerrit
Code Issues Proposed changes

Delete dead code in VisibleGroups

Browse Source 
This is now handled by account.GetGroups.

Change-Id: I338f7f14450b729ae60131678660d077caea689f
This commit is contained in:
Shawn Pearce
2013-01-18 09:45:42 -08:00
parent ef6b83bd20
commit f1b4c30305
1 changed files with 0 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
gerrit-server/src/main/java/com/google/gerrit/server/account/VisibleGroups.java
View File

@@ -87,30 +87,6 @@ public class VisibleGroups {
return filterGroups(groups.values());
}
/**
* Returns visible list of known groups for the user. Depending on the group
* membership realms supported, this may only return a subset of the effective
* groups.
* @See GroupMembership#getKnownGroups()
*/
public List<AccountGroup> get(final IdentifiedUser user) throws NoSuchGroupException {
if (identifiedUser.get().getAccountId().equals(user.getAccountId())
|| identifiedUser.get().getCapabilities().canAdministrateServer()) {
Set<AccountGroup.UUID> mine = user.getEffectiveGroups().getKnownGroups();
Map<AccountGroup.UUID, AccountGroup> groups = Maps.newHashMap();
for (final AccountGroup.UUID groupId : mine) {
AccountGroup group = groupCache.get(groupId);
if (group != null) {
groups.put(groupId, group);
}
}
return filterGroups(groups.values());
} else {
throw new NoSuchGroupException("Groups of user '" + user.getAccountId()
+ "' are not visible.");
}
}
private List<AccountGroup> filterGroups(final Iterable<AccountGroup> groups) {
final List<AccountGroup> filteredGroups = Lists.newArrayList();
final boolean isAdmin =