Merge branch 'stable-2.16'

* stable-2.16:
  Fix IAE when listing reviewers of change that has reviewers by email
  BugFix: Add documentation for 'read as' capability
  Fix assignee getting the owner's status on change list

Change-Id: Idc07fa417d75eeb8d5944cf1fc8af353d8736650
This commit is contained in:
Paladox
2018-11-30 00:04:19 +00:00
committed by Paladox none
3 changed files with 11 additions and 1 deletions

View File

@@ -1362,6 +1362,12 @@ This limit applies not only to the link:cmd-query.html[`gerrit query`]
command, but also to the web UI results pagination size.
[[capability_readAs]]
=== Read As
Allow users to impersonate any user to see which refs they can read.
[[capability_runAs]]
=== Run As

View File

@@ -165,8 +165,9 @@ limitations under the License.
hidden$="[[isColumnHidden('Assignee', visibleChangeTableColumns)]]">
<template is="dom-if" if="[[change.assignee]]">
<gr-account-link
id="assigneeAccountLink"
account="[[change.assignee]]"
additional-text="[[_computeAccountStatusString(change.owner)]]"></gr-account-link>
additional-text="[[_computeAccountStatusString(change.assignee)]]"></gr-account-link>
</template>
<template is="dom-if" if="[[!change.assignee]]">
<span class="placeholder">--</span>

View File

@@ -182,10 +182,13 @@ limitations under the License.
element.change = {
assignee: {
name: 'test',
status: 'test',
},
};
flushAsynchronousOperations();
assert.isOk(element.$$('.assignee gr-account-link'));
assert.equal(Polymer.dom(element.root)
.querySelector('#assigneeAccountLink').additionalText, '(test)');
});
test('_computeAccountStatusString', () => {