opendev/gerrit
Code Issues Proposed changes

Update git submodules

Browse Source 
* Update plugins/delete-project from branch 'master'
  to e345e6e79900a72981e4ad19d37c7fbdcae4818b
  - Fix ProtectedMembersInFinalClass error flagged by error prone
    
    Running recent error prone version complaining on that code:
    
    DeleteCommand.java:53: error: [ProtectedMembersInFinalClass] Make members
    of final classes package-private: <init>
      protected DeleteCommand(DeleteProject deleteProject, DeletePreconditions preConditions) {
                ^
        (see https://errorprone.info/bugpattern/ProtectedMembersInFinalClass)
    
    Bug: Issue 12677
    Change-Id: I3ef90ac3106240403dc88178262edf2447f30cb8
    
  - Fix JavaTimeDefaultTimeZone error flagged by error prone
    
    Running recent error prone version complaining on that code:
    
    TimeMachine.java:54: error: [JavaTimeDefaultTimeZone] Clock.systemDefaultZone()
    is not allowed because it silently uses the system default time-zone.
    You must pass an explicit time-zone (e.g., ZoneId.of("America/Los_Angeles")
     to this method.
        clock = Clock.systemDefaultZone();
                                       ^
        (see https://errorprone.info/bugpattern/JavaTimeDefaultTimeZone)
    
    Bug: Issue 12677
    Change-Id: I10e34bf90d1903aeb40810509b87b0519971ade1
This commit is contained in:
David Ostrovsky
2020-05-21 16:46:39 +02:00
committed by Gerrit Code Review
parent f480286bca
commit f89f53faf9
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files