opendev/gerrit
Code Issues Proposed changes

Merge "Update replication submodule for fixing test flakiness" into stable-3.1

Browse Source 
* submodules:
* Update plugins/replication from branch 'stable-3.1'
  to 0d91ffd189297f511c93d40a864978b5774805c1
  - Synchronize access to ReplicationTasksStorage
    
    The ReplicationTasksStorage can be subject to concurrency issues when a
    replication task is moved across directories (waiting/running/building)
    concurrently with the listing.
    
    The result of the uncontrolled concurrency could be lead to:
    
    1. Flaky tests because of the replication tasks found two or more times
       in different directories
    2. Flaky tests because of the failure to list replication tasks
       that are escaping across directories because of the rename
    3. File-based exceptions when replication tasks are moved concurrently
       by two threads to different directories.
    
    The replication tasks storage is supposed to contain only small files and only
    in-flight operations: the overhead of the additional synchronisation is thus
    negligible compared to the overall latency of the replication itself.
    
    To eliminate all residual latency, cleanup all the replication tasks
    on all subdirectories at the start of the tests.
    
    Bug: Issue 11843
    Change-Id: I5f6293b3f22f0943df79f8ab2cb2c217210e5236
This commit is contained in:
Luca Milanesio
2019-12-10 07:37:17 +00:00
committed by Gerrit Code Review
parent 7aba094fa3 1a11b40373
commit fc2ddc9678
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files