When replying to a change the 'send email' checkbox allowed to control
if the change update should trigger email notifications for other
users. This behaviour is bad for people who want to rely on email
notifications since it depends on the replying users whether they get
an email notification or not. By removing the 'send email' checkbox
people are again in control about their own email notifications, e.g.
by the watch settings they can configure which emails they want to
receive. Still suppressing email notifications via the REST API is
possible (and wanted, e.g. for CI jobs).
Change-Id: If11863da6020a1d5b7edc1ae1a1a60399b197267
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
If two commits that are merged have more than one common predecessor
the recursive merge is superior. In this situation the normal
non-recursive merge may even result in broken files without notice.
This is why the recursive merge should be enabled by default.
Change-Id: I4c5b8b2c6d406ec925da05838696c5c57f2348ef
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
The recursive merge in JGit is not new and experimental anymore.
Add a link to a blog that explains how the recursive merge works and
why it is better than the normal merge algorithm.
Change-Id: Ibeb9300d915f5702ebde9ff900db081ec1b2126e
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Add support for regex in project list screen filter. If filter start
with '^', then the filter will be interpreted as a regex.
Feature: Issue 2751
Change-Id: I1cf8a0f9fc18a6e286a2a26c71be77f1d4f16741
The description and error messages are outdated and are legacy of
the command originally being named "approve".
Change them to be more appropriate to the current usage of the
command, which is to apply reviews, which may or may not include
approvals, to patch sets.
Also rename the `approveOne` method to something more appropriate.
Change-Id: If95a24b8998bbac9a2ea410ecc05974674070e06
The exact REST command to do a PUT/POST was confusing me so adding
a more concrete example to the documentation.
I also noticed that other people had problems as well:
https://groups.google.com/d/msg/repo-discuss/lLJg59RJ5g0/4-r3SQu118wJ
Change-Id: Idd493b6a42eb3ef0a4f2001ca3449e90a71c493a
- Reword the descriptions to make them a bit easier to read.
- Fix spelling mistake.
- Remove the unnecessary `--all` option from example commands.
- Mention that the test results cache can be ignored by using
the `--no-results-cache` option.
Change-Id: Ie50ac5f2b286d96d4e88c5829c0fe0e75c132583
It is already possible to get the content of a file from the HEAD
revision of a branch. Add the same functionality for arbitrary
commits.
Change-Id: Id8e48bb40b4f383997aa9b83440a57ab90e763ee
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
The kill SSH command was adapted to make use of the new REST endpoint.
Change-Id: I7783ded83d4a027fcfeab7573101c9b6f9f69149
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
GET /config/server/tasks/ lists the task from the background work
queues.
The implementation of the SSH show-queue command was adapted so that
is uses the new REST endpoint to get the information about the tasks.
This avoids code duplication.
Change-Id: Iad0a94e8ed1395033aa7dbfe5fae0557601c3526
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
There are several settings that are only used by either the Lucene or
Solr index. Instead of saying "Only used when the type is X" for each
of those settings, reorganise them into separate subsections specific
to each index.
The sentence describing the names of the indexes mentions names that
are only correct for the Solr index. Move this under the newly created
Solr section, and add a new sentence with the correct names for the
Lucene index under the Lucene section.
Change-Id: I753895a75e7d9f8007a21b9de91a841bad257675
* stable-2.9:
Release notes for Gerrit 2.8.6.1
Remove reference to MyISAM from database setup documentation
Update version to 2.8.6.1
Upgrade gwtorm to 1.7.3
Fix reference to Forge Committer access right in documentation
Avoid avatar URL requests on load of change list
Update 2.8.6 release notes with recent fixes
Update SSHD to 0.11.1-atlassian-1
Expose Atlassian's maven repository
Update gwtorm to 1.7.1
Buck: Strip SNAPSHOT suffix in artifact names only for GERRIT repositories
Conflicts:
VERSION
lib/maven.defs
Change-Id: Iacf4e3634cf4dbd2a1b86558f06cf5cdb0e50475
* stable-2.8:
Release notes for Gerrit 2.8.6.1
Remove reference to MyISAM from database setup documentation
Update version to 2.8.6.1
Upgrade gwtorm to 1.7.3
Conflicts:
VERSION
gerrit-plugin-archetype/pom.xml
gerrit-plugin-gwt-archetype/pom.xml
gerrit-plugin-gwtui/pom.xml
gerrit-plugin-js-archetype/pom.xml
lib/BUCK
Change-Id: Ic5046ad7a73aeb67313bfe8b6af1bda42d6723c9
Due to bugs like I8aeb0c87, some changes might end up with incorrect
values of the mergeable flag. They should normally correct themselves
as the branch advances, but provide an option to the /mergeable
endpoint for the impatient.
Change-Id: I961f9dccf67373946b153bb99f4fdac73f38cac4
The access right '+2 Forge Committer or Tagger Identity' in the
'Forge Identity' category doesn't exist anymore, but was replaced by
the 'Forge Committer' access right.
Change-Id: I786579407939b66ec886645fd687220e21ccb04d
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
The show-caches SSH command now only prints out the summary
information if the caller is an administrator. This is done because
the summary information contains system information which must not be
exposed to non-administrators. This means that the behaviour is
changed and users that only have the 'View Caches' capability are not
anymore able to see the summary information as they did before.
Change-Id: I3b5433b456d3b5f9d5de872a731470d2fe20623f
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
The documentation of the /index REST API endpoint was added
with commit 4e38b97171ed4851395655435ab88d7d93da6bee but omitted
to mention that the caller must be a member of a group that is
granted the administrateServer capability.
Change-Id: Ic71dcd887e2f7ec3ea3194102aa8cd4f6c539398
