Some user groups are intolerant of any sort of new feature or
funcationalty being added to the web interface. Add a server
variable that disables or hides most new functionality.
Change-Id: Ide3a6a5e66cbba9c58575345a4a9ad1da209bb16
Checked type inference has changed slightly in Java 7, so many of the
suppressions are no longer necessary.
Change-Id: I73585e888b8204429ea67c8f4822d81d4dad8c46
Internal group names are automatically hyperlinked in the access
control editor. This makes it easy to view the members of the group
and determine if access is correctly assigned.
Plugins supplying group systems may include a url to a group
information page. If present use these URLs as hyperlinks in the
access editor, providing the same functionality.
Change-Id: I9605fdc1d43d6705a01ec2b68b083e8678dbc88a
Delete 'Anonymous Users', 'Registered Users', 'Project Owners' and
'Change Owner' from the database and account_groups table. Define
them inside of a specialized SystemGroupBackend class.
Change-Id: Ia67add4630579f3d0ce25edcfd662bbcf918dc8f
GWT only needs the rebind code for CSS and ServerLinker to be
precompiled as bytecode. Save build time by passing no source
files to the java_library() used by gwt_module().
For a full draft build of ui_safari this cuts the refresh time
down from 32.015s to 26.158s on my MacBook. Saving 6s on each
UI reload adds up during development.
The common annotations need to be provided as bytecode, avoiding
spurious warnings from GWT when there is a Java syntax error.
Change-Id: I37826498650c65c05303e7d4d1177d05781c56f6
Require the secondary index to be enabled in Gerrit 2.9. Unless
configured differently, Lucene is used for the secondary index.
Change-Id: I3d2d804170835d69ffbfef586ddc3873ea3cd1c8
Eclipse Kepler thinks these resources are unclosed.
The refactoring in JettyDaemon combines three duplicate invocations
and confuses Kepler's JDT enough that the unclosed resource warning
goes away.
Change-Id: I0f376ac6116082ed645d6712fe5d98add66f493e
If 'changeMerge.test' is set to true Gerrit checks if a change is
mergeable and shows this on the ChangeScreen. If a change is not
mergeable the submit button is hidden. There are two problems with
hiding the submit button:
1. Users get confused why the change cannot be submitted. They are
searching for the submit button and do not understand that they have
to rebase the change. Gerrit administrators are annoyed to answer
questions about this. If trying to submit the change fails there is a
good error message that tells the user that he needs to rebase the
change. This is mostly a problem with the old change screen. On the
new change screen the red "Cannot Merge" and the "Merge Conflict"
status can hardly be overlooked.
2. If a change has a conflict it is possible to resolve the conflict
in a merge commit which is a successor of the conflicting change. If
this merge commit is submitted it is in state 'Submitted, Merge
Pending'. If now the conflicting change is submitted the merge
succeeds. This way of resolving conflicts is not possible if the
submit button is not available on conflicting changes.
Since we are now always showing the submit button (if the approvals
allow submit and the user has the permission to submit) and we are
also always computing the mergeability flag for each open change,
there is no need for the 'changeMerge.test' configuration parameter
anymore. This feature is now enabled by default and the
'changeMerge.test' configuration parameter is removed.
Change-Id: I37e69e67992b3aea153e134a5f21fe76ba7e2b91
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
When users upate parent project, the default value of
parent project will be 'All-Projects' if users leave it
to be empty, just as that in ceating new project scenario,
thus users need not to recall it should be 'All-Projects'
or 'All_Project' or 'All-projects'.
Change-Id: I831da9cc5fa19c50e8754a0e2a86fc849e21f785
{@code foo} is shorter and easier to read and write than
<code>foo</code>, which is why it was introduced years ago in the
javadoc processor. Make consistent use of it throughout the
documentation comments.
Change-Id: I59d428cb6c5015453629398b0697891b83c8e91d
Get rid of updated() and just use setWrittenOn().
In PostReview create the new comment object with
the transaction timestamp rather than wall clock.
Change-Id: I4cfef0ca82bd031d1b855fa14592489bbad9d25b
Add a new column to change tables and user dashboards in which the
size of a change is visualized by a colored bar. For small changes a
short green bar is shown, for medium sized changes a middle sized
yellow bar is shown and large changes have a full red bar.
Visualizing the change sizes gives a hint to the reviewers about how
complex a change is and how long it will take to review it.
For contributors the visualization of the change size may be a
motivation to split large changes into smaller pieces which will speed
up the review process.
How many changed lines are considered as a large change is
configurable.
Change-Id: I88497b8aea00047d93ad7d079eecc5e1052187d2
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This tab makes use of the 'conflicts' operator which is only supported
if a secondary index is enabled.
Change-Id: I25cc023e10f10a80efce12c1a3e62a65cb8940f3
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
User preferences are held in memory in the accounts cache, but can be
stale in a multi-master configuration due to writes being handled on a
different server process. Paper over the lack of cache coherency by
reading the preferences from the database anytime they are requested
through the RPC or REST APIs.
Change-Id: I2a14e1f50e908a1d5ea5628e5a05e392be2e0d42
This method is not invoked by any UI code. Drop the method.
/accounts/self/preferences.diff provides the same data on
a supported REST API.
Change-Id: If88d8449f48e898fc84fdabad19341bd8063a737
Only Gerrit administrators are allowed to change the parent of a
project. Now normal users can change the parent project in the WebUI
and save the modification for review. This creates a change for the
refs/meta/config branch that can be approved and submitted by
administrators. Since the administrators are the only ones who can
submit this change they are automatically added as reviewer. This way
we have an integrated workflow for requesting and approving changes of
parent projects, instead of having requests by email outside of
Gerrit.
Change-Id: I080649990f80edf78fd6eb465cef25fb8012352d
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Cut down on a bunch of one-offs of install(new *Module() {...}) by
choosing a more appropriate base module class. This doesn't solve all
such cases, for example RpcServletModule must still inherit from
ServletModule, but it does clean up some code. (And who knows, fewer
modules may even mean faster startup time.)
Change-Id: Ie1aed05d0a64f7f11b121c9a637bb30d80e9a595
This change adds support for updating the parent project of a child
project from the WebUI. This functionality is offered in the
ProjectAccessScreen. When the access rights are changed the user is
also able to change the parent project (if the user has the needed
privileges, means if he is administrator). When the user saves the
new settings only one RPC to the server is done that updates both the
access rights and the parent project property. Technically both
updates are modifications of the 'project.config' file in the
'refs/meta/config' branch. There will be only one commit for this
file that does both updates.
In the UI only valid parent projects are suggested as new parent
project (all projects that would cause a cycle in the line of parent
projects are not suggested).
Bug: issue 1298
Change-Id: Ic63bdb039ea5057a0551138f8fef9ede280b2be3
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
