33654 Commits

Author SHA1 Message Date
Dave Borowitz
070b20504e Move ProtoGen out of gerrit.war
Putting this in the WAR dated back to the Maven days, when adding new
binary build targets was prohibitively expensive. Nobody using a
distributed gerrit.war, as opposed to building locally, actually needs
to run this binary.

This binary has a very thin dependency stack and can build in just a few
seconds, rather than having to build all of the server target, JS
bundles, and other slow pieces of gerrit.war just to generate a proto
file.

Change-Id: If6e7d981bdd57b11536ffe990d11789afd232a46
2018-08-07 08:53:18 -07:00
Dave Borowitz
de3e936507 Add missing runtime_deps to gwtorm
Change-Id: I41c547837c8275eef563bea31711e9b5a0b72189
2018-08-07 08:51:12 -07:00
Edwin Kempin
3f752726f7 Merge "Add some more comments in ReceiveCommits" 2018-08-07 12:05:51 +00:00
Han-Wen Nienhuys
2e318b2ec7 Add some more comments in ReceiveCommits
Change-Id: I693a7e13bd3d3e4c689002e951cfee6375d4f7f6
2018-08-07 13:21:14 +02:00
Han-Wen Nienhuys
ef21649900 Document that GerritPersonIdent contains a timestamp
Change-Id: I011c9463a184950f7b5ca92dcd0a8dae14650c2c
2018-08-07 13:20:10 +02:00
Han-Wen Nienhuys
15a2ec6e0f Merge "ReceiveCommits: make MessageSender immutable" 2018-08-07 11:09:56 +00:00
Edwin Kempin
888881946b Merge "AsciiDoctor, DocIndexer: Don't use deprecated CmdLineException" 2018-08-07 06:51:41 +00:00
Edwin Kempin
1f45809597 Merge "Add Localizable class to fix CmdLineException deprecation warnings" 2018-08-07 06:50:48 +00:00
Viktar Donich
83cced0a47 Import static assets in the index page, if provided.
Change-Id: Ib94abcf4408c1a6298763ce72245e58b17d62ecb
2018-08-06 12:19:37 -07:00
Han-Wen Nienhuys
f3ff7960e4 ReceiveCommits: make MessageSender immutable
Change-Id: Ibbb24aed2dec7194aff3cc14f795fb4dddcdc01e
2018-08-06 20:40:01 +02:00
Dave Borowitz
55a9a94941 Merge "Add handlebars to mime file" 2018-08-06 15:48:25 +00:00
Dave Borowitz
852d5d8c86 Merge changes I38d57c20,I7826131b
* changes:
  Upgrade JGit to 5.0.2.201807311906-r
  Merge branch 'stable-2.15'
2018-08-06 15:38:44 +00:00
Edwin Kempin
63bdcb0917 Merge "Annotate MessageSender as UsedAt(GOOGLE)" 2018-08-06 13:43:30 +00:00
Han-Wen Nienhuys
346e723fbe Annotate MessageSender as UsedAt(GOOGLE)
Change-Id: I2bc93a70ade36b0113ff11c4239095e21eca8904
2018-08-06 15:02:24 +02:00
Dave Borowitz
b5184d20c2 Merge "Add intro to documentation to describe the rationale of Gerrit code review." 2018-08-03 19:02:19 +00:00
Janet Davies
3c58389083 Add intro to documentation to describe the rationale of Gerrit code review.
Based on a draft provided by Han-Wen Nienhuys (hanwen@google.com)

Change-Id: Ib593bf6a5c78b9b5c44b062a205eb03fef926b19
2018-08-03 12:01:36 -07:00
Kasper Nilsson
266eb4f39a Merge "Enable diff headers for binary files" 2018-08-03 17:30:41 +00:00
Paladox none
26598c5b72 Add handlebars to mime file
Change-Id: I6cecb4db115d3c5b5874253a945cec1676f5acca
2018-08-03 16:58:35 +00:00
Wyatt Allen
49242ba466 Merge "Handle legacy name in change_table preferences" 2018-08-02 20:06:47 +00:00
David Pursehouse
3d9574e6c3 Upgrade JGit to 5.0.2.201807311906-r
This release contains the following fixes since 5.0.1.201806211838-r:

A fix for issue 9153:

  - ResolveMerger: Fix encoding with string; use bytes

And several fixes related to cleanup of ref directories after running
GC:

  - Delete all loose refs empty directories
  - Use java.nio to delete path to get detailed errors
  - GC: Remove empty references folders
  - Do not ignore path deletion errors

Bug: Issue 9153
Change-Id: I38d57c20475345626e277c7734fd0e109070d69e
2018-08-02 21:07:22 +02:00
David Pursehouse
03498bfdd5 Merge branch 'stable-2.15'
* stable-2.15:
  Clarify that receive.maxObjectSizeLimit does not get inherited
  Upgrade JGit to 4.9.3.201807311005-r
  Minor improvements in receive.maxObjectSizeLimit documentation
  Bazel: Consume rules_closure from HEAD
  Bump auto-value to 1.6.2
  dev-contributing: use buildifer 0.15.0

Change-Id: I7826131be3cc47fee531c292bd3ce25cf6be464f
2018-08-02 21:00:31 +02:00
David Pursehouse
665426a4df Merge branch 'stable-2.14' into stable-2.15
* stable-2.14:
  Clarify that receive.maxObjectSizeLimit does not get inherited
  dev-contributing: use buildifer 0.15.0

Change-Id: I8b3f860dd85cea062f59ba3e9b3f26aae0c6f731
2018-08-02 20:22:00 +02:00
Dave Borowitz
e81ce714a0 Revert "Simplify [ReceivePack]MessageSender logic"
This reverts commit 7c4f0c3f3070bd8f066b94cd92fcbbcf4ee36af7.

Reason for revert: Google uses a different MessageSender implementation
internally.

The rebased version of this revert keeps the cosmetic variable
renamings.

Change-Id: Ieda44268c38819dd887e9563effc794e278e6810
2018-08-02 10:46:55 -07:00
David Pursehouse
c0c935d2b3 Clarify that receive.maxObjectSizeLimit does not get inherited
Change-Id: If10ace95990a3ef032da4d700333dc76501ec9e6
2018-08-02 14:44:12 +00:00
David Pursehouse
b8644dc4bc Merge "dev-contributing: use buildifer 0.15.0" into stable-2.14 2018-08-02 14:42:02 +00:00
Dave Borowitz
6f0b8d70b9 Merge changes I1bcb67db,I63aa3df1,I3d886137
* changes:
  Cosmetic fixes in AsyncReceiveCommits callers
  Costemic changes to AsyncReceiveCommits
  Simplify [ReceivePack]MessageSender logic
2018-08-02 14:14:46 +00:00
David Pursehouse
e8e98d83e3 Upgrade JGit to 4.9.3.201807311005-r
This release contains the following fixes that were submitted on
JGit's stable-4.9 branch since the currently used snapshot was built:

A fix for issue 9153:

  - ResolveMerger: Fix encoding with string; use bytes

And several fixes related to cleanup of ref directories after running
GC:

  - Delete all loose refs empty directories
  - Use java.nio to delete path to get detailed errors
  - GC: Remove empty references folders
  - Do not ignore path deletion errors

Bug: Issue 9153
Change-Id: Ia385b5bb46e94e4a93503345648502885c61c5c9
2018-08-02 15:18:29 +02:00
David Pursehouse
39dcd91570 Merge branch 'stable-2.14' into stable-2.15
* stable-2.14:
  Minor improvements in receive.maxObjectSizeLimit documentation
  Bazel: Consume rules_closure from HEAD
  Bump auto-value to 1.6.2

Change-Id: I401942a40c5001300f77f9437d342001cd42e619
2018-08-02 15:07:21 +02:00
Han-Wen Nienhuys
fb75f4fa79 Cosmetic fixes in AsyncReceiveCommits callers
Change-Id: I1bcb67db2796cbe88212e029a8a7a861ef2b757b
2018-08-02 14:59:02 +02:00
Han-Wen Nienhuys
5d17dbd823 Costemic changes to AsyncReceiveCommits
Add javadoc, and get rid of shortened variable names.

Change-Id: I63aa3df1167c409a141eeae945e8b53d9c106251
2018-08-02 14:57:03 +02:00
David Pursehouse
c50089674f Merge "GitModule: Include target branch into log for submodule subscription" 2018-08-02 10:19:33 +00:00
Edwin Kempin
b4033e24bd GitModule: Include target branch into log for submodule subscription
We had an issue with submodule subscriptions where it would have saved
quite some work if this log would have contained the target branch.

Change-Id: Icf39746547485ea59bb4db075dde23d8a3f39a82
Signed-off-by: Edwin Kempin <ekempin@google.com>
2018-08-02 10:14:54 +00:00
David Pursehouse
2e54868448 Minor improvements in receive.maxObjectSizeLimit documentation
Change-Id: I632a2fc3de1187b476cd182112149dff2a57c606
2018-08-02 10:13:45 +00:00
David Pursehouse
0fd2313871 Merge "Merge branch 'stable-2.15'" 2018-08-02 10:00:57 +00:00
David Pursehouse
ba1151c20d AsciiDoctor, DocIndexer: Don't use deprecated CmdLineException
These classes don't really need to throw a CmdLineException because
the provided CmdLineParser is never actually used when reporting the
error to the user.

Replace the deprecated CmdLineException with IllegalArgumentException.

Change-Id: I52efc3d70177cbaa4ae9c0d945b4afc558f504d2
2018-08-02 11:30:11 +02:00
David Pursehouse
dc1d42d2f6 Add Localizable class to fix CmdLineException deprecation warnings
In the updated version of args4j the constructor:

  CmdLineException(CmdLineParser, String)

is deprecated in favor of:

  CmdLineException(CmdLineParser, Localizable, String...)

Add a new Localizable class that implements the expected interface,
and replace usage of the deprecated constructor across the Gerrit code
except in AsciiDoctor and DocIndexer. The latter don't really need to
use CmdLineException; this will be fixed in a separate commit.

Change-Id: I7033c0dd764780a163953ca9fc39da228ac20707
2018-08-02 11:13:17 +02:00
Edwin Kempin
c7b8ff45a4 Merge changes Idc3b9656,I315661dc
* changes:
  PatchSetUtil: Remove static modifier from setGroups method
  TagSet: Add default serialVersionUID
2018-08-02 06:46:22 +00:00
Edwin Kempin
c516df6135 Merge "Add missing @Override annotations for args4j methods" 2018-08-02 06:45:46 +00:00
Makson Lee
28781f5ab8 Implememts equals/hashCode in FileInfo
Change-Id: I119c5817efb385c98e72c74835f0f33a1921f55b
2018-08-02 00:26:32 +00:00
Wyatt Allen
3b5ae7518d Handle legacy name in change_table preferences
After updating the "Project" column name to "Repo", there were still
references to the former name in the change_table preference, which
controls what columns appear in the change table. Because, following the
rename, preferences would have an outdated key, this had the unintended
effect of hiding the repo column by default for any user who had
modified that preference.

With this change, the appearance of "Project" in a change_table list is
treated like an appearance of "Repo".

Bug: Issue 9509
Change-Id: I1e773b5dd07dd086551f62aacbbe5973078e9ee4
2018-08-01 16:11:23 -07:00
Wyatt Allen
d5336b5582 Merge "Show whether diff sides lack trailing newlines" 2018-08-01 21:23:07 +00:00
David Ostrovsky
4b8fff2d06 Bazel: Consume rules_closure from HEAD
Now, that both changes were merged, consume rules_closure from HEAD
and avoid patching it during the build: [1].

[1] d1c92e34f2
Change-Id: I5afeccb17e4ef76b2ec86f9f8b7f2741bf8d4e93
2018-08-01 22:48:43 +02:00
Kasper Nilsson
7723e319b8 Merge "Give disabled delete vote button a style" 2018-08-01 20:44:42 +00:00
Kasper Nilsson
d8cf5bf82b Merge "Fix change-star in change view" 2018-08-01 20:44:29 +00:00
Kasper Nilsson
bbd286781c Fix change-star in change view
Regression caused by 08ab3aa2 -- the change-star element no longer makes
API calls, instead relying on the parent component.

Bug: Issue 9511
Change-Id: I26faee7ab9158687ec939c48592f3a263cffc93e
2018-08-01 20:44:15 +00:00
David Ostrovsky
5531347e56 Bump auto-value to 1.6.2
This upgrade is needed to support JDK9, that was fixed in this
commit: [1].

[1] f04406c1f1

Change-Id: Ic7464964dc7e21946aac4b4a786107a0df51ae2a
2018-08-01 22:35:35 +02:00
Wyatt Allen
d13f4185a7 Show whether diff sides lack trailing newlines
Show a small warning at the end of a diff if either side does not have a
trailing newline. When a diff loads, find the last chunk for both sides
and examine the last line of each chunk. If the newline is missing from
either or both, show a corresponding message.

Keep track of whether the diff component is loading using a _loading
property so that the message can be hidden when loading a new diff.

Feature: Issue 9459
Change-Id: I59f59de5676af2f0352a42aa6d7dabaad5fc65b4
2018-08-01 13:31:43 -07:00
Kasper Nilsson
932882f64f Merge "Modernize image diff layout" 2018-08-01 20:10:45 +00:00
Kasper Nilsson
2a3f59fdab Modernize image diff layout
As per UX instructions, adds a border between the images and replaces
the image outline with a box shadow.

Change-Id: Iec157ce7e346cab217a49d6fcee5977c1702478c
2018-08-01 12:29:19 -07:00
Kasper Nilsson
1c9e0534fe Give disabled delete vote button a style
Change-Id: I51883c5216db095de965d7e300b3cc214d4d7fe4
2018-08-01 11:52:37 -07:00