4 Commits

Author SHA1 Message Date
Wyatt Allen
292d013f32 Decode inheritance project IDs before use
In the JSON of emitted by the repo list endpoint, the project IDs are
URL-encoded using java.net.URLEncoder.encode. While the Java function
encodes spaces as plus-signs, the JavaScript decodeURLComponent does
not.

As a result, when editing the "inherits from" field of a project's
access settings where the parent project's ID includes spaces, the
payload would use an improperly decoded parent value, and this would be
rejected by the API for failing to identify the parent.

Add a new decoding method to the URL encoding behavior that better
matches the style of encoding used by java.net.URLEncoder. Because the
behavior had no test coverage before, it's moved to a new location and
a suite of tests are added. Add tests for the access screen properly
encoding and decoding parent IDs.

Change-Id: Icb1d28d8f1f88c3c7373aa1c8953238a61c32ace
2018-07-30 18:25:47 -07:00
Dave Borowitz
8cdc76ba4c Add @license tags to PG HTML and JS assets
These tags are preserved by the Closure compiler and vulcanize in order
to serve the license notices embedded in the outputs. In a standalone
Gerrit server, these license are also covered in the LICENSES.txt served
with the documentation. When serving PG assets from a CDN, it's less
obvious what the corresponding LICENSES.txt file is, since the CDN is
not directly linked to a running Gerrit server. Safer to embed the
licenses in the assets themselves.

Change-Id: Id1add1451fad1baa7916882a6bda02c326ccc988
2018-03-26 10:47:55 -04:00
Paladox none
9ab73ef9df PolyGerrit: Add support for creating annotated tags
Change-Id: I614ba3b3b848a052cb30cb5ac3b184b65de6d4dd
2017-09-14 18:07:19 +00:00
Paladox none
2d67b7c5a5 PolyGerrit: Implement support for creating branches and tags
This adds a new dialog called "gr-create-pointer-dialog" which is used
to create branches or tags.

Change-Id: I5614a1642c45010b7af61135859a4d52f79fb87a
2017-08-03 17:56:19 +00:00