7 Commits

Author SHA1 Message Date
Dave Borowitz
8cdc76ba4c Add @license tags to PG HTML and JS assets
These tags are preserved by the Closure compiler and vulcanize in order
to serve the license notices embedded in the outputs. In a standalone
Gerrit server, these license are also covered in the LICENSES.txt served
with the documentation. When serving PG assets from a CDN, it's less
obvious what the corresponding LICENSES.txt file is, since the CDN is
not directly linked to a running Gerrit server. Safer to embed the
licenses in the assets themselves.

Change-Id: Id1add1451fad1baa7916882a6bda02c326ccc988
2018-03-26 10:47:55 -04:00
Kasper Nilsson
1b5d74bb0a Add keyword-spacing lint rule
This rule enforces consistent spacing around keywords and keyword-like
tokens.

Also fixes any errors introduced by addition of the rule.

Bug: Issue 6390
Change-Id: I206aa10e36d1a1e46ff0b76b48e54658ae91471c
2017-06-02 11:12:50 -07:00
Kasper Nilsson
fbad19e18e Catch-all fix for merged linter errors
Bug: Issue 6179
Change-Id: I436b6dbd88e83b4d901d5446a0c7900678be157d
2017-05-17 17:17:25 -07:00
Viktar Donich
b288dc1361 Move reviewer updates back in time to appear before reply message
Feature: Issue 5984
Change-Id: I75974028180e06fa18f8e1ba5b8a1f2ea9885010
2017-05-17 10:55:15 -07:00
Kasper Nilsson
cfa942a78b ES6ify /gr-rest-api-interface/*
Bug: Issue 6179
Change-Id: I27e4b8a39b63d794388f027c817ef12ae1b1d504
2017-05-16 19:27:04 +00:00
Viktar Donich
0f1296ffe6 Do not parse partially filled changes for reviewer updates
Skip reviewer updates grouping for changes that:
- don't have messages
- don't have reviewer updates

Issue 5421

Change-Id: I3edcc3f5b1110506be5f23fcdf37a6bf40fc70c9
2017-02-02 12:39:52 -08:00
Viktar Donich
95c868e1fd Group reviewer updates in the UI (parser)
Introduces GrReviewerUpdatesParser that processes individual reviewer
updates and groups them. This essentially moves implementation from
/c/94490/ to client side to gather requirements ahead of server-side
implementation. Ultimately, this class will simply be removed once
server-side generates grouped updates.

Sequential updates are grouped if:
- They were performed within short timeframe (6 seconds)
- Made by the same person
- Non-change updates are discarded within a group
- Groups with no-change updates are discarded (eg CC -> CC)

Bug: Issue 4383, Issue 5256
Change-Id: Ieb405d4b5562294adb23bdd14879e9e67737890f
2017-01-31 21:23:17 -08:00