8963 Commits

Author SHA1 Message Date
David Pursehouse
211cd6f76a Merge "Include username in REST example for getting change details" 2013-10-16 15:19:38 +00:00
David Pursehouse
d79c63ba13 Merge "Fix inclusion of username if detailed account information is requested" 2013-10-16 15:18:31 +00:00
Fredrik Luthander
a3cf3548a8 Config file documentation: refs/meta/config and capabilities
Adds general information about global capabilities, how the server
ownership is administered and what it looks like underneath, i.e.
refs/meta/config.

Change-Id: Ia0da5d692b7f3c43c4471668944bdcc9de3b3cd6
Signed-off-by: Fredrik Luthander <fredrik.luthander@sonymobile.com>
Signed-off-by: David Pursehouse <david.pursehouse@sonymobile.com>
Signed-off-by: David Ostrovsky <david@ostrovsky.org>
2013-10-16 16:52:12 +02:00
Edwin Kempin
65886f0e1e Include username in REST example for getting change details
Getting change details includes detailed account information, but the
example didn't show the username for the AccountInfos.

Change-Id: If0ff49924e3aa57cee087f16f3087304488f957b
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
2013-10-16 15:04:59 +02:00
Edwin Kempin
4a00e22d70 Fix inclusion of username if detailed account information is requested
The documentation of AccountInfo claims that the username is included
if detailed account information is requested but this was not the
case.

Change-Id: Ic28cadb6b7236ce69b60cb9d237fe18eae01e8e0
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
2013-10-16 14:34:24 +02:00
Edwin Kempin
e1537dcce3 Merge "Update the replication and reviewnotes plugins" 2013-10-16 08:24:21 +00:00
David Pursehouse
df254424f0 Update the replication and reviewnotes plugins
This updates the plugins to versions that are adapted to the
simplified GitReferenceUpdatedListener.Event API.

Change-Id: I0d01639c4738945aafd3920acdfbe26cf23c176b
2013-10-16 10:22:37 +02:00
Edwin Kempin
8d8d26b374 Merge "Simplify the GitReferenceUpdatedListener.Event API" 2013-10-16 08:17:49 +00:00
David Pursehouse
455d7bc2b1 Improve output of .war name during site initialisation
The init always refers to gerrit.war, although the actual name
of the file may be different.

Change it to display the actual name of the file that was used
to install.

Change-Id: Ifb05773570f9c2c842d851a98cd59947a2d34698
2013-10-16 16:44:56 +09:00
Sasa Zivkov
c573d8abf6 Simplify the GitReferenceUpdatedListener.Event API
So far the Event exposed the getUpdates method which implied that one
Event could contain updates of more than one reference. However, we
never made use of that feature. The only implementation of the Event
always returns only one Update.

The assumption that one Event could contain more than one reference
Update also made coding in [1] more complex than necessary.

This change simplifies that API in the sense that one Event corresponds
to one ref update only.

[1] https://gerrit-review.googlesource.com/#/c/50351/2/src/main/java/com/googlesource/gerrit/plugins/replication/PushResultProcessing.java

Change-Id: Ifdb27e22ae83f30a6af7f0b4e6bf6acbd85fe6e4
2013-10-16 14:13:08 +09:00
David Pursehouse
13b2190cc9 Fix typo in documentation of anonymousCoward name configuration
Change-Id: Ie6e205de70a4e8c7f5a4df3622984522f8797e13
2013-10-16 12:59:18 +09:00
David Pursehouse
b35d314d2f Merge "Merge branch 'stable-2.7'" 2013-10-16 03:28:06 +00:00
Edwin Kempin
a5c3ef93ab Merge "Remove unnecessary throws OrmException" 2013-10-15 15:05:28 +00:00
Edwin Kempin
acf2f29b5c Merge "Update gwt-test-utils" 2013-10-15 14:29:58 +00:00
Hugo Ares
3b6acb9325 Remove unnecessary throws OrmException
PostEvent using the branch does not throw OrmException

Change-Id: I696a4a2db94c1ea301a04db9ebb4c63e498aed53
2013-10-15 09:27:02 -04:00
David Pursehouse
c4e3524594 Merge branch 'stable-2.7'
* stable-2.7:
  Sync 2.7 release notes from master
  Sync release notes from master
  Fix: Review comments do not show up for unchanged files

Change-Id: Ia7ad03f4b6e4507dc346b35ee3e70adf26c577e3
2013-10-15 22:11:24 +09:00
David Pursehouse
26797376a9 Sync 2.7 release notes from master
The release notes were updated on the master branch, but did not
get synced the the 2.7 branch.  Release notes build from stable-2.7
are not up to date.

Change-Id: If581bc8283e37755b38f52a000ca501e4a769928
2013-10-15 22:09:17 +09:00
David Pursehouse
618989cef9 Merge branch 'stable-2.6' into stable-2.7
* stable-2.6:
  Sync release notes from master
  Fix: Review comments do not show up for unchanged files

Change-Id: I68828f7debf75e03956703acdf4a03e1462c3af9
2013-10-15 22:08:51 +09:00
David Pursehouse
dd1ef1d114 Sync release notes from master
The release notes on master were updated to use links to the new
download site, but those updates were not reflected on the
stable-2.6 branch.

Also the release note for 2.6.1 is missing on stable-2.6, but
instead the release note for 2.6.2 (which does not exist) is
there.  And there are several older release notes missing.

Sync the release notes from master to make them consistent.

Change-Id: I8facc676aeff754f092a5a9a7bf69345229a55f0
2013-10-15 22:02:10 +09:00
David Pursehouse
550ba8a8b6 Fix potential NPE in DocIndexer
Change-Id: Iba859bc5b6122671990e5c7af5e72ee69f57f96d
2013-10-15 11:05:14 +09:00
David Pursehouse
a89b53acb3 Merge "Alpha sort submodules" 2013-10-15 02:02:41 +00:00
David Pursehouse
dad9b9fb5f Merge "AbstractQueryChangesTest: avoid possible NPEs on teardown" 2013-10-15 02:01:57 +00:00
David Pursehouse
2e54ff65dc Merge "Update 2.8 release notes with new library versions" 2013-10-15 01:58:47 +00:00
Dave Borowitz
32b53b6db4 AbstractQueryChangesTest: avoid possible NPEs on teardown
Change-Id: I517c77fca3a3a40767137296dc55d129855af809
2013-10-14 16:01:58 -07:00
Dave Borowitz
7a2d8d4e61 Fix last line of license headers
This was due to a copy/paste error into my editor's snippet library,
and it managed to sneak into 20 classes without anybody noticing.

Change-Id: Ifeea9ab5737acbed1b93519b65709f1c0f48684b
2013-10-14 17:40:17 +00:00
Dave Borowitz
b2de915be3 Merge "Remove direct Lucene dependency from InMemoryModule" 2013-10-14 15:31:08 +00:00
Edwin Kempin
048cf106bf Alpha sort submodules
Change-Id: I43eaef21650c6d8f4aff5c5e7365dd6f4222d13a
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
2013-10-14 08:45:54 +02:00
David Ostrovsky
5116a4f6b6 Update 2.8 release notes with new library versions
Change-Id: I82c3b28e38aa6b67b18276c746a69d0f6f845f76
2013-10-13 18:36:46 +02:00
David Pursehouse
acc5159f85 Update gwt-test-utils
The currently specified version is no longer available on the
repository.

Update the BUCK config to use the latest release.

Change-Id: I918ef3fe3f899d5ab4682114586084f99a324403
2013-10-12 12:11:43 -04:00
Shawn Pearce
1a2d39fd17 Merge "SideBySide2: Keep content visible when showing dialogs and popdowns" 2013-10-12 01:53:47 +00:00
Shawn Pearce
592c1441df SideBySide2: Keep content visible when showing dialogs and popdowns
Set the z-index of our widgets to 200. The highest z-index used by
CodeMirror3 is 100.

Bug: issue 2110
Change-Id: Ic3fd04db5deeba8649b3675509403e3f652b071d
2013-10-11 16:41:38 -07:00
Shawn Pearce
c15bf97181 SideBySide2: Restore standard diff colors
The colors addded by 9294f6610d340d3 were too subtle and made it
very hard to see the shading or read the diff. Revert back to the
prior color scheme.

Change-Id: Iedebeb07c034947f160ced45c71a3b7e191ef82c
2013-10-11 16:30:16 -07:00
Dave Borowitz
a1fe821470 Remove direct Lucene dependency from InMemoryModule
Custom secondary index implementations should be able to use this
module for writing index tests without linking against Lucene.
However, for other potential uses of this module for tests within
Gerrit, it makes sense to still use Lucene by default without
installing any additional modules. So, as a hack, keep the Lucene
dependency but construct it via reflection.

The same argument could be made about the H2 cache dependency, but the
specific use case we are interested in at the moment is the index
implementation, so extract that one first.

Change-Id: I7d213a9f233b819ec0bc6632323e65ac9b270200
2013-10-11 16:11:15 -07:00
Shawn Pearce
c7230a14bd Merge "Update 2.8 release notes with recently merged changes" 2013-10-11 22:29:42 +00:00
Shawn Pearce
8e2ecd2c89 Merge "Allow gitweb URLs to be passed unencoded for viewing." 2013-10-11 22:27:32 +00:00
Dave Borowitz
a1f315bd03 Factor testutil classes into their own java_library
Change-Id: I83f8e355cccfae4d566ce436eadbb352b86522df
2013-10-11 14:11:57 -07:00
Dave Borowitz
1134051b48 Add a handful of tests for querying changes
This covers a good fraction of search operators for both SQL and
Lucene index types. Over the course of this several bugs and
inconsistencies in the existing implementations were discovered; some
have been fixed in previous changes, and some have the corresponding
assertions commented out in this change.

In addition to the few simple operators not yet covered, we do not yet
test many forms of compound queries.

Change-Id: I6e14116a56fc2a352f99bea930d6aed297c0749d
2013-10-11 14:11:57 -07:00
Dave Borowitz
fac1fa5930 Teach InMemoryModule to work with custom index types
Change-Id: Iac9b5b825878069783f98aaf77352ff4533a49b6
2013-10-11 14:11:57 -07:00
Dave Borowitz
fb5744b065 Extract an abstract test case for querying changes
Add implementations for SQL and Lucene backends.

Convert to JUnit 4 so we can use @Ignore on the test, as Buck's test
runner does not skip abstract classes.

Change-Id: I1a9b6ed53e27cab81ea88ff4e8fece8e999596e0
2013-10-11 14:11:57 -07:00
Dave Borowitz
8122f7edb0 In-memory tests for searching changes
Use InMemoryModule to inject everything needed to manually insert
commits into a repo and changes into a database, then query the
results.

Change-Id: I22f6d663039039dd4d3f2189e587dbd22f11252b
2013-10-11 14:09:53 -07:00
Dave Borowitz
ceeff43182 Support creating Lucene indexes in-memory
Control this with a config option, which is the easiest way to get it
injected. Do not document the option as it should just be used for
tests.

Change-Id: Ic7d5dd5e7a3495079bacc2c2830feb0af1fe6188
2013-10-11 12:29:23 -07:00
Dave Borowitz
4652d348a4 Move InMemoryDatabase setup into a module
Storing the injector in the InMemoryDatabase instance was a hack.
Instead, move towards a more comprehensive Guice stack for tests by
moving this setup into a module.

Keep the same manual create()/drop() behavior of InMemoryDatabase,
though eventually we may want to do something with LifecycleManagers
and move towards a similar idiom to that used in the acceptance tests.

Change-Id: I917f6dab4751541fa63bfe3318818fbe4bda20f2
2013-10-11 12:29:23 -07:00
Shawn Pearce
fabc680bf5 Merge "Update replication plugin to latest revision" 2013-10-11 19:28:15 +00:00
Shawn Pearce
1793ffb390 Merge "Fix status:closed query" 2013-10-11 19:27:30 +00:00
Shawn Pearce
ef0a26bab3 Merge "If two plugins contribute the same top menu display it only once" 2013-10-11 18:00:45 +00:00
Edwin Kempin
87a550bf03 If two plugins contribute the same top menu display it only once
Change-Id: I0985c7fae987c45e58ab81d6ca04d03f4e858a5c
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
2013-10-11 10:58:23 -07:00
Dave Borowitz
25078217ad Fix status:closed query
There was no rewrite rule matching this so the query processor
helpfully ANDed in status:open. Add one.

Change-Id: Ia9afcf0661d6e89d633588db3d0e7f4f60488477
2013-10-11 10:53:53 -07:00
Dave Borowitz
0f62e836d5 Bind caches as eager singletons
All H2 caches must be created before the enclosing LifecycleManager
starts, therefore they must be created eagerly. If they are not, it is
possible for an assisted factory to attempt to create the cache for
the first time only when that factory's create() method is called (as
opposed to when the factory is injected).

Change-Id: I058d8783161ffc4274dd78337842ce55c53de183
2013-10-11 10:47:30 -07:00
Dave Borowitz
5e9470a98f Return InMemoryRepository from InMemoryRepositoryManager
Change-Id: I0cb9501b5a8d4190bc4929d35264da9edff0c850
2013-10-11 10:47:29 -07:00
Dave Borowitz
88a274019f Run indexing in sameThreadExecutor when index.threads <= 0
Change-Id: I3fb5a2ec039335cd8962b4a0973fbff7de55842f
2013-10-11 10:47:29 -07:00