Add a new DataSource interface that provides the read() method.
Make ChangeDataSource extend this interface.
This will allow additional data source interfaces to be defined
later, for example an account data source that can be used by
a secondary index of user accounts.
Change-Id: I73b1858a5bffb9dbac459f295e04ef4610873d01
* stable-2.9:
Update repository in pom.xml of plugin archetypes
Release documentation: Add URL to Gerrit artifacts on Maven Central
Change-Id: Ic68d210412841b04831a7a865fb8fc1232c8138f
The plugin artifacts are no longer published to the Google Cloud
Storage but to Maven Central.
To reference released artifacts from Maven Central it is not necessary
to specify a repository in the pom.xml. This is because by default
Maven tries to find any artifact in Maven Central.
The Gerrit snapshots artifacts are now published to the Sonatype
snapshot repository [1], hence this repository must be specified in
the pom.xml if snapshot artifacts are referenced.
[1] https://oss.sonatype.org/content/repositories/snapshots/
Change-Id: Iac7d1b6e6957a9bcc43a42fab9d85dc111d46246
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
For snapshot versions the archetype repository must be explicitly
specified. If no archetype repository is specified Maven tries to
download the artifacts from Maven central, but there only release
artifacts are available.
Change-Id: Id4ddcff482bd98da89a79a2c76e483a55baad9df
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
* stable-2.9:
Update archetype version in plugin documentation to 2.9
Conflicts:
Documentation/dev-plugins.txt
Change-Id: I6636ca2acd5a242b37a26c04597c31ebb4222ece
Released artifacts first appear in the Sonatype releases repository
and are only then replicated to Maven Central. Clarify this in the
release documentation.
Change-Id: Ie50a41685222a4423d9fde727e5af29691ca2c8d
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
When 2.9 is released plugin developers should be able to copy and
paste the archetype command from the plugin documentation. For this
the version should match the released version. The command will work
only after the 2.9 plugin artifacts have been published to Maven
Central.
Change-Id: I4188c3740536f31eb49be2091cc89630da6cda96
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
* stable-2.9:
Release docs: Describe in more details how to publish to Maven Central
Document more details about the deploy configuration for Maven Central
ChangeScreen2: Respect user preference for unified diff view
Change-Id: I423c9ce62d3f33d2ecf6c0c8cd2e669c09693976
* stable-2.9:
Release docs: describe how to upload the WAR to the Google Cloud Storage
Minor fixes in release documentation
Describe in the release documentation how to update versions
Conflicts:
Documentation/dev-release.txt
Change-Id: I270673cd9a96d3bc755f4bfe0dbc7c7fc0777172
Publishing the WAR file is more important than publishing the plugin
artifacts. This is why the section that describes the publishing of
the WAR file should come first.
Change-Id: Ibc0bea4d8a70a1b737f62ff4c9978fb0081d720d
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
The List Comments endpoint is a little confusing because users
expect this to get file as well as message comments. This
endpoint only retrieves the former, not the latter. Message
comments can be retrieved with the Get Change Detail endpoint.
This change just updates the docs to be more clear.
Issue: 2693
Change-Id: Id4fcbcaa0e755cc650cbaaf07b57dbae7e4a370f
* stable-2.9:
Recheck change mergeability status on restore
Add missing documentation of changes REST API index endpoint
Update plugin owned capabilities documentation
Populate CodeReviewCommit before passing to MergeValidators
Change-Id: Ia65a58b137f29b4c21b4c8cc44fb3b12033fc62c
Mention in first sentence that capabilities can be also used with
UiActions. Also fixes small copy-paste error from UiActions section.
Change-Id: I686e7b40f04216367751b8829295973fa6fa2c09
Signed-off-by: Dariusz Luksza <dariusz@luksza.org>
The onPreMerge method of MergeValidationListener may reasonably
assume that the fields of CodeReviewCommit are populated, for example
that commit.notes() will not NPE. The previous ordering of code in
MergeOp.validateChangeList() made this assumption false.
Change-Id: I9bd9e76bb09a25faf57df7080cdb0c8f878a7471
It seems like new REST endpoints don't include "kind" attribute. This
change removes it from the code and documentation.
Change-Id: Ia73fb92ce01461e7de140b138fc72583b00170bc
When adding the ChangeKind for JSON data, I added it into
PatchSetCreatedEvent which ended up being a pretty lousy place to
add it, since it has little to do with the event, and more to do
with the PatchSetAttribute itself. This moves the data to the
PatchSet JSON structure, alongside the draft attribute.
Change-Id: Ia3791789af2ddb6efc70d78f38595519b5d6ab5f
Ia2ac8cfcc moved some REST endpoints to singleton scope, but missed
to remove providers from these endpoints, where they get injected.
When a singleton injects another singleton, this is only an overhead
to inject it as a provider to singleton and not directly.
Change-Id: I6d6f361cc2c46440845ef13ccacb8ec4f28c9b36
Ibe3547942 renamed "Submit" button to "Merge Change" with justification
why to prefer "Merge Change" label over "Submit".
I5d7e1d21a reverted that change and restored it back to "Submit" with
another justification for why "Merge Change" can be misleading.
This change externalize the label name and tooltip for Submit button
to enable site administrator to customize it.
Bug: issue 2667
Change-Id: Iec78b31051f6b0022af1f337f5d492b78c7df096
* stable-2.9:
SideBySide2: Do not offer 'r' keybinding to anonymous users
SideBySide2: Hide reviewed checkbox if not signed in
Fix AccountInfo.has_avatar_info() that wrongly always returns true
Anonymous users cannot mark a file as reviewed, as the server
has no way to track the stored flag. Disable the keybinding
so it does not appear in the help dialog.
Change-Id: I415a24754d1b4b5120b5b40e074ee697cf921b52
Users cannot mark a file as reviewed unless they are signed in, as the
server needs the user identity to store the reviewed flag. The checkbox
is hidden on ChangeScreen2 for anonymous users, so hide it in SBS2.
Change-Id: I96605222fab5ab0cb64c157b51dc4ca92ec4732d
