When using the web ui (both old and new ChangeScreen) to cherry-pick a
change to a branch that already has this change (e.g.: cherry-picking
on the same branch to get rid of dependencies), the corresponding
patchset-created event had its patchSet.uploader set to the Change's
owner instead of the current user. We now set it to the current user,
so stream-events consumers can properly detect who uploaded the
rebased patch set.
Change-Id: I0613ecae06b7843b8ca0294f83378c3917c26810
The JavaDoc generation reported the following warning:
.../EmailReviewCommentsExecutor.java:29: warning - Tag @link:
reference not found: EmailReviewComments
Change-Id: If30a0e08ccbcea0ee55d208cc2dc6840c4dab00e
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
(cherry picked from commit a5d2ad3933bd021d6a5a947642bf14bcfd1b998b)
In the top right corner of a file the navigation cluster has a
tooltip on the up arrow but did not show the tooltip on the left
or right arrows. Show the key in the tooltip.
Change-Id: I192ef0ab8155c15b4bb35a18da33f74f15bb5537
If a group contains more than 'addreviewer.maxWithoutConfirmation'
members adding it as reviewer to a change requires a confirmation. A
user should only be asked for the confirmation when reviewers are
added from the WebUI but not when the set-reviewers SSH command is
used. This is also how 'addreviewer.maxWithoutConfirmation' is
documented in 'config-gerrit.txt'.
Bug: issue 2599
Change-Id: Ieab601e573115a0b034e1dcebe1c602adda6770b
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
The project list screen was taking a long time to render over a large
amount of projects (1,000+) and with even larger number of projects
(3,000+), it could make the browser unresponsive.
Project list screen now uses pagination to resolve this issue. The
number of projects displayed is determined by the 'Maximum Page Size'
user preference.
Bug: issue 2215
Change-Id: Icd0a7d54fd5c5b3c2301c31026e7c6717a648a24
List projects endpoint has an option to limit the number of results
returned but it was missing an option to start at a nonzero offset in
order to support results paging.
Add and document 'S' option which allow to query project list starting
at a nonzero offset. Also add missing documentation for the 'n' option
which limits the number of results.
Those 2 options will be then used to render project list with pagination
in web UI.
Change-Id: I19c4cd1cfa6ed78f22c84f249af54a5c30387561
Every time key up event is raised in the project list filter text box,
the project list was getting refreshed even if the filter did not
change (e.g. moving the cursor was refreshing the list).
Only call the refresh if the filter changed or if enter key is pressed.
Change-Id: I2e608d89e16dbef0cfe1e503ac2feb4639c27f5d
In the new change screen, if the user clicks on a binary file in
the file list, the unified view is used. Then when navigating to
a previous or next file that is not binary, the diff view stays in
the old unified setting. It is only possible to get back to the
new side-by-side view by going back to the change screen and then
opening the non-binary file from there.
To keep consistent behavior of diff view, always use unified diff
for binary files. Use the user's preference setting for non-binary
files.
Change-Id: Ie4ece4cb740df8a69cbf3d2d42e4b0fb05461520
3daa739e13 took care of firing the ref-updated event for updates via the
web UI access pane, but not changes via the web UI general pane, which
uses the REST 'PUT /projects/:project-name/config' endpoint. This commit
takes care of that case, as well as the REST
'PUT /projects/:project-name/description' endpoint.
Note: there's still no ref-updated event for the case of changing a
project from "hidden" state back to read-only or "active" as hooks are
suppressed for hidden projects deeper in the code.
Bug: Issue 2571
Change-Id: I0a260011c0968193ccb5900a18935e654d25f042
Add missing @ExtensionPoint in ChangeListener so implementors can use
@Listen to register.
Change-Id: Ia7fd16a7afdffbfc278880317fd10297f8b9e19d
(cherry picked from commit eff0592a70ce7fb3dee91abd5262dd462339591e)
Sometimes it is found that one thread goes stuck when waiting
for an answer from the SMTP server.
Fixed. Enable user to
-config the timeout value of opening a socket connected to a remote
SMTP server.
-config the worker-thread pool size of executor used for sending out
review comments notification when it is not enough to dedicate only
one thread.
-config the default size of the background execution thread pool when
one thread is not enough to handle miscellaneous tasks including
sending out every kind email notification.
Change-Id: Id8177b374f7049cfac617c50e66b2c83ae71641b
The SubIndex.NrtFuture objects are added as listeners of
searchManager who was found to hold on to them forever.
Fixed. There are also some code refactoring in NrtFuture.
Change-Id: If87cb62890a1cfa6c6336f6c7953a1cb56d42937
It is odd to put block expansion link only on number of skipped lines.
This change puts link on whole sentence "... skipped XX common lines
...".
Change-Id: I5c48a26fa7fa8758e35386994b80ef741e3ffa50
Signed-off-by: Dariusz Luksza <dariusz@luksza.org>
Running the script in the root of the Gerrit folder:
./tools/version NEW_VERSION
will replace the value in the first occurrence of the <version> tag
in the plugin archetype pom files with the value specified by
NEW_VERSION.
Change-Id: I9f529852af22a1eef7f30e2fcaea8acea28057d9
The GWT compiler swamps a system when it builds, using multiple
threads to build each permutation in parallel. It also requires
a lot of RAM. Buck is not aware of the cost of the genrule and
currently schedules both to build at the same time.
Make ui_opt depend on ui_dbg so Buck is forced to serialize these
build steps, reducing the load on average systems while possibly
extending build time on very powerful (e.g. 16 core) systems.
Change-Id: Icc1856c9c4e7919c28dc533e792fa25aadcdf801
This commit changes the mysql setup documentation because
there is no need to use latin1 encoding if you are using
another engine than the MyISAM engine.
Bug: Issue 1273
Change-Id: I432957381385c3e0390bb0db245139954300ecb8
(cherry picked from commit 13d07ecc7cd98cfd928a2b06d8755aea1fddde61)
When pushing changes it is easy to make a typo in the refspec and
in this case new branches should not be created. If administrators
want to create branches by push they should explicitly assign
themselves the needed access rights.
This was broken by [1].
[1] https://gerrit-review.googlesource.com/#/c/54048/
Change-Id: I768bfd6d7cb193b0ec9f51c3fa768087ceb91acd
Bug: Issue 2557
Disable the 'commitWithin' from within Reindex by overriding
the configuration with '-1'. Treat negative values as the
original behavior, auto-flushing but not auto-committing, which
is the least safe but the most efficient for reindexing the
entire site.
Change-Id: Ifdba797bee871d2a3d8928810a6304bacb850c8c
After editing the commit message and pressing "save", the button
remains active until the message is saved and the dialog is closed.
Usually the edit completes quickly, but on some systems where the
network is slow it can take a few seconds. If the user presses the
"save" button again (perhaps more than once) it will result in more
than one edit request being sent. This can in some cases result in
inconsistency between the database and the git repository, which
prevents the change from being viewed any more until a new patch set
is manually uploaded.
Disable the "save" button after it has been pressed, to prevent this.
Change-Id: I820095a1d91b7fd7c498c7c24fa5e7e81e40a7eb
As the owner still can't create a branch by pushing a reference over
ssh I think the previous statement isn't as clear as it could be.
Original commit 7ec4ac71ffa58f32e1443b0ca0110417244983c0 seems to
only deal with the create-branch command, not changing the behavior
over creating a reference by pushing it (over ssh).
Change-Id: Iac3f52b10ee6a92862622e8699c5daa1d4749247
Signed-off-by: Fredrik Luthander <fredrik@gandaraj.com>
Escape dollar sign in plugin manifest entries, to prevent that
it is interpreted by the shell and thus get removed.
Change-Id: Iefd8abdcd207cb985f8156c7e41c094c1aa12b27
Move the paragraphs about running the reindex program and the index
names up to the top of the index section. It makes more sense to
have them there, than in the middle of the setting descriptions.
Change-Id: I875a66173f752554803ca95bc166fba0dfbcd315
If the commitWithin setting is low, it can cause the reindex to
run slowly. Add a note in the documentation about this.
Change-Id: If4c394443bde89be4bfc1505d33322089e671493
