* stable-2.8:
Release notes for Gerrit 2.8.4
Set uploader to current user in "patchset-created" event upon cherry-picking
Fix JavaDoc warning
Conflicts:
gerrit-server/src/main/java/com/google/gerrit/server/change/CherryPickChange.java
Change-Id: I28791a3ff28de4d20ded64e180d7ddb02a4e4687
When using the web ui (both old and new ChangeScreen) to cherry-pick a
change to a branch that already has this change (e.g.: cherry-picking
on the same branch to get rid of dependencies), the corresponding
patchset-created event had its patchSet.uploader set to the Change's
owner instead of the current user. We now set it to the current user,
so stream-events consumers can properly detect who uploaded the
rebased patch set.
Change-Id: I0613ecae06b7843b8ca0294f83378c3917c26810
The JavaDoc generation reported the following warning:
.../EmailReviewCommentsExecutor.java:29: warning - Tag @link:
reference not found: EmailReviewComments
Change-Id: If30a0e08ccbcea0ee55d208cc2dc6840c4dab00e
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
(cherry picked from commit a5d2ad3933bd021d6a5a947642bf14bcfd1b998b)
The JavaDoc generation reported the following warning:
.../EmailReviewCommentsExecutor.java:29: warning - Tag @link:
reference not found: EmailReviewComments
Change-Id: If30a0e08ccbcea0ee55d208cc2dc6840c4dab00e
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
* stable-2.8:
SideBySide2: Show [ and ] shortcut keys in nav arrow tooltips
Always auto confirm adding reviewers for set-reviewers SSH command
Improve wording of 'parents' field description in CommitInfo
Fix 'parents' field name of CommitInfo in REST documentation
Implement pagination in project list screen
Add option 'S' to projects REST API to support query offset
Fix: Failure of acceptance tests.
Do not refresh project list if filter did not change
Fix inconsistent behavior of diff view when viewing binary files
Update cookbook plugin to latest revision
Correct Javadoc of RestReadView in extension API
Fix memory leak of SubIndex.NrtFuture objects
Conflicts:
gerrit-gwtui/src/main/java/com/google/gerrit/client/Dispatcher.java
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/Header.java
gerrit-server/src/main/java/com/google/gerrit/server/change/PostReviewers.java
Change-Id: I4d432c6ce27d3fd76dd9f86b8685be15ec8f123d
In the top right corner of a file the navigation cluster has a
tooltip on the up arrow but did not show the tooltip on the left
or right arrows. Show the key in the tooltip.
Change-Id: I192ef0ab8155c15b4bb35a18da33f74f15bb5537
If a group contains more than 'addreviewer.maxWithoutConfirmation'
members adding it as reviewer to a change requires a confirmation. A
user should only be asked for the confirmation when reviewers are
added from the WebUI but not when the set-reviewers SSH command is
used. This is also how 'addreviewer.maxWithoutConfirmation' is
documented in 'config-gerrit.txt'.
Bug: issue 2599
Change-Id: Ieab601e573115a0b034e1dcebe1c602adda6770b
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
* stable-2.8:
Emit ref-updated event when editing project access via web UI
Fix ChangeListener auto-registered implementations
Fix: The email notification of review comments gets stuck.
Use consistent grammatical tense in command descriptions
Make skip bar more user friendly
Bump version to 2.8.4 in plugin API and archetypes
Helper script to update API version in plugin archetype pom files
Serialize GWT dbg and opt compiles
Bump GERRIT_VERSION to 2.8.4
Update the mysql documentation concerning charsets
By default don't allow admins to create new branches by push
Disable commitWithin when running Reindex
Emit ref-updated event when editing project access via web UI
SideBySide2: Fix syntax highlighting for shell files
ChangeScreen2: Respect comment visibility strategy
Don't add "Patch File" download link for merge commits
The change 'ChangeScreen2: Respect comment visibility strategy' [1]
is dropped intentionally, see [2].
[1] https://gerrit-review.googlesource.com/55081
[2] https://gerrit-review.googlesource.com/#/c/55536/3/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/History.java
Conflicts:
Documentation/config-gerrit.txt
VERSION
gerrit-gwtui/BUCK
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.java
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DownloadBox.java
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/History.java
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SkipBar.java
gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/ChangeProjectAccess.java
gerrit-plugin-archetype/pom.xml
gerrit-plugin-gwt-archetype/pom.xml
gerrit-plugin-gwtui/pom.xml
gerrit-plugin-js-archetype/pom.xml
gerrit-server/src/main/java/com/google/gerrit/server/change/EmailReviewComments.java
gerrit-server/src/main/java/com/google/gerrit/server/project/PutConfig.java
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ListMembersCommand.java
Change-Id: I16c848cb385080fd25555c983a3030e0f1cc560b
The project list screen was taking a long time to render over a large
amount of projects (1,000+) and with even larger number of projects
(3,000+), it could make the browser unresponsive.
Project list screen now uses pagination to resolve this issue. The
number of projects displayed is determined by the 'Maximum Page Size'
user preference.
Bug: issue 2215
Change-Id: Icd0a7d54fd5c5b3c2301c31026e7c6717a648a24
List projects endpoint has an option to limit the number of results
returned but it was missing an option to start at a nonzero offset in
order to support results paging.
Add and document 'S' option which allow to query project list starting
at a nonzero offset. Also add missing documentation for the 'n' option
which limits the number of results.
Those 2 options will be then used to render project list with pagination
in web UI.
Change-Id: I19c4cd1cfa6ed78f22c84f249af54a5c30387561
In the change info panel there are links on the project name, branch
name, and topic name. They all behave differently:
project: opens the project admin page
branch: opens a query for changes on the branch and topic
topic: opens a dialog to edit the topic name
Also, next to the project is a query icon that opens the project
default dashboard which is a query for recent changes.
These inconsistent links reduce the useability of the UI. With this
change, they are made more consistent:
project: opens the project default dashboard
branch: opens a query for changes on the branch (without topic)
topic: opens a query for changes on the topic
The project query icon is replaced with a settings icon that opens
the project admin page. The topic can still be edited by clicking
on the edit icon.
Change-Id: I09c36bf80949efd8a6237669c8284275c3372d9c
I do not recall why I added this message box below the topic name
field in ChangeScreen2. I suspect the original idea was to permit
more notes to be added, for example why the topic is being assigned.
At the recent Gerrit hackathon it sounded like nobody ever uses this
box. Remove it to simplify the UI.
Also remove message from the PutTopic REST API. We suspect nobody
will notice the missing field.
Change-Id: I8d32287ee3b08d9409dd7d58688cd9effdfd380f
Mention that the 2.9 release includes all the fixes that were
included in the releases 2.8.1 through 2.8.4.
Change-Id: I124d2149ee3f3e604128eefa01d60453b9d54619
Every time key up event is raised in the project list filter text box,
the project list was getting refreshed even if the filter did not
change (e.g. moving the cursor was refreshing the list).
Only call the refresh if the filter changed or if enter key is pressed.
Change-Id: I2e608d89e16dbef0cfe1e503ac2feb4639c27f5d
In the new change screen, if the user clicks on a binary file in
the file list, the unified view is used. Then when navigating to
a previous or next file that is not binary, the diff view stays in
the old unified setting. It is only possible to get back to the
new side-by-side view by going back to the change screen and then
opening the non-binary file from there.
To keep consistent behavior of diff view, always use unified diff
for binary files. Use the user's preference setting for non-binary
files.
Change-Id: Ie4ece4cb740df8a69cbf3d2d42e4b0fb05461520
3daa739e13 took care of firing the ref-updated event for updates via the
web UI access pane, but not changes via the web UI general pane, which
uses the REST 'PUT /projects/:project-name/config' endpoint. This commit
takes care of that case, as well as the REST
'PUT /projects/:project-name/description' endpoint.
Note: there's still no ref-updated event for the case of changing a
project from "hidden" state back to read-only or "active" as hooks are
suppressed for hidden projects deeper in the code.
Bug: Issue 2571
Change-Id: I0a260011c0968193ccb5900a18935e654d25f042
Add missing @ExtensionPoint in ChangeListener so implementors can use
@Listen to register.
Change-Id: Ia7fd16a7afdffbfc278880317fd10297f8b9e19d
(cherry picked from commit eff0592a70ce7fb3dee91abd5262dd462339591e)
Sometimes it is found that one thread goes stuck when waiting
for an answer from the SMTP server.
Fixed. Enable user to
-config the timeout value of opening a socket connected to a remote
SMTP server.
-config the worker-thread pool size of executor used for sending out
review comments notification when it is not enough to dedicate only
one thread.
-config the default size of the background execution thread pool when
one thread is not enough to handle miscellaneous tasks including
sending out every kind email notification.
Change-Id: Id8177b374f7049cfac617c50e66b2c83ae71641b
The SubIndex.NrtFuture objects are added as listeners of
searchManager who was found to hold on to them forever.
Fixed. There are also some code refactoring in NrtFuture.
Change-Id: If87cb62890a1cfa6c6336f6c7953a1cb56d42937
When a project config is updated or a change is merged, all open
changes on an entire project or branch need to be rechecked for
mergeability. For projects or branches with lots of open changes,
this can flood the queue with potentially slow checks. This will
block simpler cases, such as checking mergeability of a single change
during ReceiveCommits.
Define a new Priority enum on the MergeabilityChecksExecutor so we
can split the queue based on priority, allowing smaller, interactive
changes such as pushes to not wait for the entire queued backlog.
Change-Id: I57f9eb33dbbcd8a560adfe4458ce48d7b0817957
This class was growing with various permutations of change, project,
branch, sync/async, which are suited to constructing with a Builder.
We also want to add a priority flag to certain checks to support more
fine-grained scheduling.
In general, due to the strategy of kicking off async work that can
fan out and ignoring errors, try to log errors as they happen instead
of depending on callers to call get() on the resulting Futures.
Change-Id: Ia575793e5ceb5aa3148b45a9a49e4e10e50a5108
It is odd to put block expansion link only on number of skipped lines.
This change puts link on whole sentence "... skipped XX common lines
...".
Change-Id: I5c48a26fa7fa8758e35386994b80ef741e3ffa50
Signed-off-by: Dariusz Luksza <dariusz@luksza.org>
In 8e78797190ddb9e04f93190bae86fe3956f08b3d, in migration change from
Jetty 8 to Jetty 9 one special case was missing: maxQueued = 0. By
mapping this value to max capacity of the queue without extra check
for the 0 value makes Jetty fail to start with IllegalArgumentException
when httpd.minThreads (default 5) smaller then maxQueued.
Rectify it by assigning Integer.MAX_VALUE to maxQueued when 0 was set.
Adjust the documenatation to reflect this change.
Change-Id: I686cf75a0bd0af16983e52ba22e7957a65cbb5b9
Running the script in the root of the Gerrit folder:
./tools/version NEW_VERSION
will replace the value in the first occurrence of the <version> tag
in the plugin archetype pom files with the value specified by
NEW_VERSION.
Change-Id: I9f529852af22a1eef7f30e2fcaea8acea28057d9
The GWT compiler swamps a system when it builds, using multiple
threads to build each permutation in parallel. It also requires
a lot of RAM. Buck is not aware of the cost of the genrule and
currently schedules both to build at the same time.
Make ui_opt depend on ui_dbg so Buck is forced to serialize these
build steps, reducing the load on average systems while possibly
extending build time on very powerful (e.g. 16 core) systems.
Change-Id: Icc1856c9c4e7919c28dc533e792fa25aadcdf801
This commit changes the mysql setup documentation because
there is no need to use latin1 encoding if you are using
another engine than the MyISAM engine.
Bug: Issue 1273
Change-Id: I432957381385c3e0390bb0db245139954300ecb8
(cherry picked from commit 13d07ecc7cd98cfd928a2b06d8755aea1fddde61)
When pushing changes it is easy to make a typo in the refspec and
in this case new branches should not be created. If administrators
want to create branches by push they should explicitly assign
themselves the needed access rights.
This was broken by [1].
[1] https://gerrit-review.googlesource.com/#/c/54048/
Change-Id: I768bfd6d7cb193b0ec9f51c3fa768087ceb91acd
Bug: Issue 2557
Disable the 'commitWithin' from within Reindex by overriding
the configuration with '-1'. Treat negative values as the
original behavior, auto-flushing but not auto-committing, which
is the least safe but the most efficient for reindexing the
entire site.
Change-Id: Ifdba797bee871d2a3d8928810a6304bacb850c8c
