08bac5cac3
Use the existing CacheBuilder#expireAfterAccess method for in-memory caches. This configuration is not respected for persistent H2 caches. There is already an "accessed" column, so in theory we could compare the current time to the value in this column. However, this has the problem that the column is not updated on every lookup against the outer memory cache which wraps the H2 cache; it's only updated when the value isn't in the memory cache and needs to be read into the memory cache from storage. As a result, the most frequently accessed elements in the in-memory cache would be the first elements to expire from the persistent cache. Rather than allowing this perverse behavior, just ignore expireAfterAccess in the H2 implementation, and document it properly. Elements may still get pruned from the cache when it exceeds the configured size. (The pruning code actually uses the accessed column and thus may be subject to the perverse behavior we're trying to avoid, but fixing it is beyond the scope of this change.) It would be theoretically possible to update the accessed timestamp in the H2 database on every read from the memory cache, but cache reads are extremely frequent and this would likely put too much write load on the H2 database. Change-Id: I881df14bcabde1376145eed815f69d7493751574
Gerrit Code Review
Gerrit is a code review and project management tool for Git based projects.
Objective
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
Documentation
For information about how to install and use Gerrit, refer to the documentation.
Source
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Reporting bugs
Please report bugs on the issue tracker.
Contribute
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
Getting in contact
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
License
Gerrit is provided under the Apache License 2.0.
Build
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
Install binary packages (Deb/Rpm)
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Use pre-built Gerrit images on Docker
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.