Go to file
Yacob Yonas 0c2d49a4f0 Refactor ChangeNotes: Make superclass AbstractChangeNotes
There will be many similarities with how we will be reading into the
ChangeNotes from the traditional notedb ref for a change and how we
will be reading draft comments from the users ref in the all users
repository. Therefore, I made a super class for ChangeNotes,
AbstractChangeNotes, that extends VersionedMetaData so that I can
utilize those same methods and instance variables in the
DraftCommentsNotes (or whatever it's called). Additionally, there was
a method for reading comments from the tree of a commit inside the
ChangeNotes.Parser, so I extracted that into the CommentsInNotesUtil
so that I can reuse that method in the parser of DraftCommentsNotes
(or whatever it's called).

I had the option to either make the AbstractChangeNotes class a raw
type with the actual inheritor extending Notes and specifying its own
type or modify all callers to add an explicit cast to ChangeNotes
whenever they use load(). I think that the former is the cleaner
alternative, so that's what I did.

Finally, the parseComments() method wasn't using the argument it was
being passed so I got rid of that as well.

Change-Id: I88513bdeb7d0ca8e4aba52254f2c3ccc10bd2ce1
2014-07-11 17:20:03 -07:00
2014-07-10 16:14:47 +09:00
2013-11-30 01:53:00 -08:00
2014-05-04 12:54:17 +02:00
2014-07-10 16:14:47 +09:00
2014-07-10 16:14:47 +09:00
2013-11-28 22:56:51 -08:00
2014-07-10 16:14:47 +09:00
2014-07-11 16:24:03 +09:00
2014-06-24 20:40:48 +00:00
2014-05-27 09:58:38 +09:00
2013-11-09 07:45:00 +01:00
2014-05-19 11:41:31 -07:00
2008-11-14 16:59:34 -08:00
2009-03-27 20:20:10 -07:00
2014-07-10 16:14:47 +09:00
Description
RETIRED, Gerrit as used by OpenStack
120 MiB