opendev/gerrit
Code Issues Proposed changes
RETIRED, Gerrit as used by OpenStack
11,258 Commits 1 Branch 360 Tags 120 MiB
10969b185d
Go to file
Saša Živkov 10969b185d Inject InitStep members again before calling postRun. 
InitStep instances are created before a site is initialized and the set
of injectable objects is quite small at that time. This also limits
what could be done from the postRun method, which is invoked after site
is initialized.

After the site is initialized a sysInjector is already available and
we could make use of it in order to perform optional injection and
provide the InitStep.postRun with additional useful objects. This way
the postRun can perform many more things than before.

To make use of the optional injection in an InitStep one would write
something like:

  public class MyInitStep implements InitStep {

    private final ConsoleUI ui;

    @Inject
    MyInitStep(ConsoleUI ui) {
      this.ui = ui;
    }

    @Override
    public void run() throws Exception {
      ...
    }

    @Inject(optional = true)
    void setGitRepositoryManager(GitRepositoryManager git) {
      gitManager = git;
    }

    @Override
    public void postRun() throws Exception {
      // make use of gitManager
    }
  }

Change-Id: Idfd04747f45db8c7e0aee892175245ccd280d5e0
2014-11-07 09:58:39 +01:00
.settings Eclipse: Bump java source and target level to 7 2013-11-29 00:15:50 +01:00
contrib Allow to download reposize.sh script from Gerrit 2014-05-09 16:20:51 +02:00
Documentation Allow to raise BooleanQuery limit in gerrit.config. 2014-10-21 14:33:57 +00:00
gerrit-acceptance-tests Disable Gitweb for in-memory acceptance tests 2014-10-21 15:04:39 -04:00
gerrit-antlr Remove unused .gitignore 2013-11-28 22:56:51 -08:00
gerrit-cache-h2 Merge "Remove unused @SuppressWarnings" 2013-11-29 08:08:53 +00:00
gerrit-common Remove fixed limit of results returned by secondary index query 2014-09-08 15:23:51 +00:00
gerrit-extension-api Set version to 2.9.1 2014-09-09 15:29:08 +02:00
gerrit-gwtdebug Prevent StackOverflowError in JettyTreeLogger 2014-02-07 12:54:18 +00:00
gerrit-gwtexpui Change CopyableLabel to hide onKeyUp 2014-05-12 18:08:56 -05:00
gerrit-gwtui Fix comment box font colors of dark CM themes 2014-10-20 23:57:36 +01:00
gerrit-gwtui-common Introduce Gerrit gwtui common project 2014-02-17 22:54:00 +01:00
gerrit-httpd Fix JS plugin load when using non-root Gerrit URLs 2014-09-08 15:52:13 +00:00
gerrit-launcher Use public getter to retrieve name from JarFile 2014-03-18 23:16:35 +01:00
gerrit-lucene Allow to raise BooleanQuery limit in gerrit.config. 2014-10-21 14:33:57 +00:00
gerrit-main Build Main for Java 1.2 2013-11-30 01:53:00 -08:00
gerrit-openid Bump Jetty version to stable 9.1 and Servlet API to 3.1 2014-01-04 22:28:10 +01:00
gerrit-patch-commonsnet Replace 'for' loop with 'foreach' 2013-12-04 01:02:53 +04:00
gerrit-patch-jgit Apply "type inference for generic instance creation" Java 7 feature 2014-01-25 17:51:08 +01:00
gerrit-pgm Inject InitStep members again before calling postRun. 2014-11-07 09:58:39 +01:00
gerrit-plugin-api Set version to 2.9.1 2014-09-09 15:29:08 +02:00
gerrit-plugin-archetype Set version to 2.9.1 2014-09-09 15:29:08 +02:00
gerrit-plugin-gwt-archetype Set version to 2.9.1 2014-09-09 15:29:08 +02:00
gerrit-plugin-gwtui Set version to 2.9.1 2014-09-09 15:29:08 +02:00
gerrit-plugin-js-archetype Set version to 2.9.1 2014-09-09 15:29:08 +02:00
gerrit-prettify Correct fix for potential NPE in PrettyFormatter 2014-03-04 11:14:56 +01:00
gerrit-reviewdb MergeabilityChecker: Fix isStale() optimization 2014-06-14 15:25:20 +02:00
gerrit-server Fix IncludingGroupMembership.containsAnyOf infinite loop 2014-10-16 05:37:07 +00:00
gerrit-solr Merge changes Iac79af54,Ief41eccc,Iae52ade9,I0bd9eabb,I2ef5b9e1 2014-02-13 17:02:23 +00:00
gerrit-sshd Don't require secondary index when running daemon in slave mode 2014-09-08 17:41:44 +02:00
gerrit-util-cli Save GWT compile time by avoiding javac 2013-11-30 11:06:50 -08:00
gerrit-util-ssl Remove unused .gitignore 2013-11-28 22:56:51 -08:00
gerrit-war Set version to 2.9.1 2014-09-09 15:29:08 +02:00
lib Bump gwtorm to 1.14 - solves the primary key column order bug 2014-11-04 15:57:39 +00:00
plugins Update replication plugin to latest revision 2014-10-23 17:40:17 +09:00
ReleaseNotes Fix ordering of 2.9.x releases in the release notes index. 2014-10-22 19:14:59 +09:00
tools Merge "Gracefully handle buck audit failure" into stable-2.9 2014-09-05 09:10:37 +00:00
website/releases Exclude gerrit-snapshot-* from releases page 2014-02-19 05:56:00 +00:00
.buckconfig Move gerrit.war from api_{install,deploy} to war_{install,deploy} 2014-05-20 06:41:08 +00:00
.buckversion Update Buck 2013-11-29 10:50:59 -08:00
.gitignore Buck: Deploy plugin artifacts to Maven Central 2014-05-26 22:06:42 +02:00
.gitmodules Add singleusergroup plugin 2013-11-09 07:45:00 +01:00
.pydevproject Set python version back to 2.6.5 in .pydevproject 2013-05-20 11:36:08 +09:00
BUCK Merge branch 'stable-2.8' into stable-2.9 2014-05-01 12:44:01 -07:00
COPYING Initial project setup of Gerrit 2 2008-11-14 16:59:34 -08:00
INSTALL Remove Gerrit 1.x to 2.x import tools 2009-03-27 20:20:10 -07:00
SUBMITTING_PATCHES Update push URL in SUBMITTING_PATCHES 2012-03-29 00:57:14 -04:00
VERSION Set version to 2.9.1 2014-09-09 15:29:08 +02:00