RETIRED, Gerrit as used by OpenStack
Go to file
Dave Borowitz 1531f6101a Support arbitrary reviewer strings in push options
This change alters the semantics of adding reviewers/CCs during push to
match the semantics of the Post Reviewers endpoint. The fact that they
differed is mostly an accident of history: support for adding reviewers
over push long predates reviewers-by-email or any of the other fanciness
added to Post Reviewers in the past few years.

The most significant semantic change is increasing the space of allowed
reviewers via push option:
  * By email, if the project allows it.
  * Group names.

For now at least, attempting to add a non-existing reviewer still fails,
whether due to a non-existing email when reviewers by email are not
supported, or a non-email input. The error message in this case has
changed to align with the error message from the REST API.

Due to an issue in the implementation of GroupResolver, adding groups
via push currently only works for internal groups if the group is
visible to anonymous users. This is still strictly more functionality
than before, when groups weren't supported at all, so keep the behavior
even with this known bug.

Change-Id: I24c0c27664d04f431e5b0f0c854df4a6de2ac014
2018-10-15 08:13:39 -07:00
.settings Merge branch 'stable-2.14' into stable-2.15 2018-05-16 08:15:29 +09:00
antlr3 Bazel: Move java/com/google/gerrit/index:query_parser to antlr3 package 2018-08-31 06:35:46 +02:00
contrib abandon_stale.py: Optionally exclude WIP changes 2018-08-30 16:14:45 +09:00
Documentation Merge changes Iab7b1f67,Iae9eef38 2018-10-10 14:49:33 +00:00
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/git Merge branch 'stable-2.15' 2018-10-10 08:37:01 +09:00
gerrit-gwtdebug Migrate all remaining classes to Flogger 2018-06-05 13:14:12 +02:00
gerrit-gwtui Remove unused value assignments 2018-09-20 14:58:05 +02:00
gerrit-gwtui-common Avoid Collections#sort 2018-09-05 09:53:01 -07:00
gerrit-plugin-gwtui Set version to 2.15.5 2018-10-08 17:16:02 +09:00
java Support arbitrary reviewer strings in push options 2018-10-15 08:13:39 -07:00
javatests Support arbitrary reviewer strings in push options 2018-10-15 08:13:39 -07:00
lib Merge branch 'stable-2.14' into stable-2.15 2018-10-08 10:57:40 +09:00
plugins Update git submodules 2018-10-01 16:30:08 +00:00
polygerrit-ui Merge "Add avatar image to settings" 2018-10-10 19:43:40 +00:00
prolog Extract prolog predicates from gerrit-server:server rule 2017-10-31 11:02:36 -04:00
prologtests Isolate gerrit:server rule in gerrit/server package 2017-10-31 11:02:38 -04:00
proto Optionally persist ExternalIdCache 2018-08-24 10:39:39 -07:00
resources Append $assetsBundle using templates rather than + 2018-09-27 14:24:32 -07:00
tools Bazel: Add support for Java 10 2018-09-25 07:31:33 +00:00
webapp Dissolve gerrit-war top-level directory 2017-10-31 11:02:37 -04:00
.bazelproject Exclude bin directory from IntelliJ Bazel project 2018-05-21 11:44:17 -04:00
.bazelrc Migrate tools/bazel.rc to .bazelrc 2018-08-10 15:55:52 +01:00
.editorconfig Added continuation indent to editorconfig 2016-04-26 14:42:58 +02:00
.git-blame-ignore-revs Update git hyper-blame configuration 2017-02-17 16:35:50 +09:00
.gitignore Remove outstanding references to buck 2018-02-07 09:16:41 -05:00
.gitmodules Modify plugins:core to build codemirror-editor 2017-12-09 00:59:31 +01:00
.mailmap Update .mailmap 2018-04-18 08:52:53 +02:00
.pydevproject Update PyDev project to use Python 2.7 2014-10-02 15:16:44 +09:00
BUILD Bazel: Add support for Java 10 2018-09-25 07:31:33 +00:00
COPYING Initial project setup of Gerrit 2 2008-11-14 16:59:34 -08:00
INSTALL Remove Gerrit 1.x to 2.x import tools 2009-03-27 20:20:10 -07:00
README.md README: use HTTPS protocol 2018-06-15 10:27:42 +00:00
SUBMITTING_PATCHES Add step to SUBMITTING_PATCHES to ensure Change-Id 2018-01-11 20:35:37 +00:00
version.bzl Set version to 2.15.5 2018-10-08 17:16:02 +09:00
WORKSPACE Merge branch 'stable-2.15' 2018-10-10 08:37:01 +09:00

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.