1e5fc1fdf6
git receive-pack was leaking a database connection per execution because we we created a new context when the command started, in order to set the access path to GIT. This meant that Guice setup the RequestScoped ReviewDb instance inside of the new context, but our thread management code ran cleanup inside of the old one. So we never actually cleaned up that per-request connection. When making a new context recursively in an SSH command, chain the new context's RequestCleanup into the old context's RequestCleanup, thereby ensuring we'll clean up both contexts when the command exits. Change-Id: I0980cafaf47728d2fe5a5b4c750a7a7217e30868 Signed-off-by: Shawn O. Pearce <sop@google.com>