opendev/gerrit
Code Issues Proposed changes
RETIRED, Gerrit as used by OpenStack
6,517 Commits 1 Branch 360 Tags 120 MiB
23050e196c
Go to file
Shawn Pearce 23050e196c Gracefully fail when submit_rule/1 has no solutions 
If a submit_rule is coded with no solution for a change, e.g.:

  submit_rule(submit()) :- fail.

the server used to crash with 500s from a number of REST APIs,
caused by a ClassCastException inside of SubmitRuleEvaluator.

An empty result list is not a ListTerm, it is a SymbolTerm and using
the NIL instance '[]'. This cannot be cast to a ListTerm for return
to the caller.

Instead return List<Term> and handle the conversion, ensuring an
empty list is returned to callers when there are no results.

Change-Id: Iea1211afb2f3970ba98ea1eff14df07452cf5ccd
2013-04-19 10:28:11 -07:00
contrib TrivialRebase: Adapt to labels in 2.6 2013-04-18 09:25:53 +03:00
Documentation Update PostgreSQL createuser example 2013-04-18 21:12:17 -07:00
gerrit-acceptance-tests Support triggering GC for one project via REST 2013-03-26 15:06:08 -04:00
gerrit-antlr Allow {} to be used for quoting in query expressions 2012-12-03 09:59:14 -08:00
gerrit-cache-h2 Fix various warnings 2012-10-18 13:38:51 +02:00
gerrit-common Fix: wrong error message on MyWatchedProjectsScreen 2013-04-09 22:22:54 +08:00
gerrit-extension-api Support triggering GC for one project via REST 2013-03-26 15:06:08 -04:00
gerrit-gwtdebug Import gwt-dev dependency as last in gerrit-gwtdebug 2012-11-19 14:35:34 +01:00
gerrit-gwtui Remove deprecated methods from FormatUtil 2013-04-18 09:47:57 +09:00
gerrit-httpd Include [NE,P] on rewrite rules for Apache proxy 2013-04-18 16:59:54 -07:00
gerrit-launcher Remove servlet-api from WAR/lib 2012-10-21 21:25:25 -07:00
gerrit-main Update versions in pom's to start Gerrit 2.6 development 2012-08-22 14:09:52 +02:00
gerrit-openid Remove unused import 2013-04-18 09:17:27 +09:00
gerrit-package-plugins Package rc0 of core plugins 2013-03-21 11:31:24 -07:00
gerrit-patch-commonsnet Update versions in pom's to start Gerrit 2.6 development 2012-08-22 14:09:52 +02:00
gerrit-patch-jgit Update JGit to 3.0 APIs 2013-03-18 09:56:26 -07:00
gerrit-pgm Remove unused getAuthType method from InitHttpd 2013-04-18 09:15:52 +09:00
gerrit-plugin-api Allow plugins to contribute InitStep to Gerrit init. 2012-10-22 10:07:31 -07:00
gerrit-plugin-archetype Update versions in pom's to start Gerrit 2.6 development 2012-08-22 14:09:52 +02:00
gerrit-plugin-gwt-archetype Update plugin-gwt-archetype to match current implementation 2012-11-12 19:55:53 +01:00
gerrit-plugin-gwtui Bump GWT version to 2.5.0 2012-11-17 05:20:19 +01:00
gerrit-plugin-js-archetype Update plugin-js-archetype to match current implementation 2012-11-12 19:55:49 +01:00
gerrit-prettify Add clarification comment in SparseFileContent.Range.toString 2013-02-19 09:58:45 +09:00
gerrit-reviewdb Remove separate label field from PatchSetApproval 2013-03-22 17:18:52 -07:00
gerrit-server Gracefully fail when submit_rule/1 has no solutions 2013-04-19 10:28:11 -07:00
gerrit-sshd Fix parameter checking on ls-projects command 2013-04-16 09:54:38 +09:00
gerrit-util-cli Add options to refs/for/ magic branch syntax 2013-02-27 16:07:30 -08:00
gerrit-util-ssl Update versions in pom's to start Gerrit 2.6 development 2012-08-22 14:09:52 +02:00
gerrit-war Break IntraLineDiff threads into their own module 2013-02-20 11:20:17 -08:00
ReleaseNotes Document Apache needs AllowEncodedSlashes NoDecode 2013-04-16 19:11:28 -07:00
tools Exclude all pom.xml files that are archetype resources in version.sh 2012-12-06 17:41:54 +01:00
.gitignore Adding sublime project files to .gitignore 2012-11-02 10:20:21 -04:00
COPYING Initial project setup of Gerrit 2 2008-11-14 16:59:34 -08:00
INSTALL Remove Gerrit 1.x to 2.x import tools 2009-03-27 20:20:10 -07:00
pom.xml Upgrade Apache SSH dependency to 0.6.0 2013-04-09 20:10:01 +08:00
SUBMITTING_PATCHES Update push URL in SUBMITTING_PATCHES 2012-03-29 00:57:14 -04:00