opendev/gerrit
Code Issues Proposed changes
RETIRED, Gerrit as used by OpenStack
10,410 Commits 1 Branch 360 Tags 120 MiB
2474e52beb
Go to file
Paul Fertser 2474e52beb Make Code-Review label values' meaning clear to non-maintainers 
Currently the labels look like a direct suggestion to a maintainer
dealing with the change, but even being interpreted this way, -1 label
sounds strange as "didn't submit" doesn't match the fact nobody has
submitted anything yet.

What's worse, new contributors have every right to assume that the
message is addressing them, and upon receiving an email saying "I
would prefer you didn't submit this" they mistakenly think that the
word "submit" refers to their action of posting for review, there's
nothing to indicate this part is directed to the maintainer. Also,
most people have never seen the "Submit" button, that's a process
detail known to the maintainers but not the general public.

This is confirmed by real-life observations of contributors to the
OpenOCD project, I know at least three persons who got somewhat
offended by receiving such a message from the review system.

Change-Id: I035a615a6caf6e085edd5827f3bfe33342156324
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
2014-01-23 10:42:41 +04:00
.settings Eclipse: Bump java source and target level to 7 2013-11-29 00:15:50 +01:00
contrib Add contrib/ui-api-proxy.go for testing UI features with live data. 2013-12-18 09:07:02 -08:00
Documentation Make Code-Review label values' meaning clear to non-maintainers 2014-01-23 10:42:41 +04:00
gerrit-acceptance-tests Add acceptance test for change REST API options 2014-01-22 12:13:49 -08:00
gerrit-antlr Remove unused .gitignore 2013-11-28 22:56:51 -08:00
gerrit-cache-h2 Merge "Remove unused @SuppressWarnings" 2013-11-29 08:08:53 +00:00
gerrit-common Mark LabelTypes maps volatile 2014-01-15 12:06:18 -08:00
gerrit-extension-api Plugin API: Add method for adding reviewers with string as argument 2014-01-17 23:59:25 +01:00
gerrit-gwtdebug Remove unused .gitignore 2013-11-28 22:56:51 -08:00
gerrit-gwtexpui SideBySide2: Restore focus to CM B after showing key binding help 2014-01-17 16:13:51 -08:00
gerrit-gwtui Merge "Respect servlet context path in URL for top menu items" 2014-01-21 22:52:45 +00:00
gerrit-httpd Bump Jetty version to stable 9.1 and Servlet API to 3.1 2014-01-04 22:28:10 +01:00
gerrit-launcher Use try/multi-catch for some reflection-related exceptions 2013-12-27 13:02:28 -08:00
gerrit-lucene Eliminate potential NPEs with ChangeData.getChange() 2014-01-03 09:10:45 -08:00
gerrit-main Build Main for Java 1.2 2013-11-30 01:53:00 -08:00
gerrit-openid Bump Jetty version to stable 9.1 and Servlet API to 3.1 2014-01-04 22:28:10 +01:00
gerrit-patch-commonsnet Replace 'for' loop with 'foreach' 2013-12-04 01:02:53 +04:00
gerrit-patch-jgit Save GWT compile time by avoiding javac 2013-11-30 11:06:50 -08:00
gerrit-pgm Define module for having group related Guice bindings in one place 2014-01-17 15:06:05 +00:00
gerrit-plugin-api Bump Jetty version to stable 9.1 and Servlet API to 3.1 2014-01-04 22:28:10 +01:00
gerrit-plugin-archetype Update Gerrit API version to 2.8.1 in pom files 2014-01-15 09:46:58 +09:00
gerrit-plugin-gwt-archetype Update Gerrit API version to 2.8.1 in pom files 2014-01-15 09:46:58 +09:00
gerrit-plugin-gwtui Update Gerrit API version to 2.8.1 in pom files 2014-01-15 09:46:58 +09:00
gerrit-plugin-js-archetype Update Gerrit API version to 2.8.1 in pom files 2014-01-15 09:46:58 +09:00
gerrit-prettify Save GWT compile time by avoiding javac 2013-11-30 11:06:50 -08:00
gerrit-reviewdb SideBySide2: Add preference for a subset of supported CM3 themes 2014-01-21 14:36:20 -08:00
gerrit-server Make Code-Review label values' meaning clear to non-maintainers 2014-01-23 10:42:41 +04:00
gerrit-solr Eliminate potential NPEs with ChangeData.getChange() 2014-01-03 09:10:45 -08:00
gerrit-sshd Start migration to notedb implementation of PatchSetApprovals 2014-01-08 11:58:24 -08:00
gerrit-util-cli Save GWT compile time by avoiding javac 2013-11-30 11:06:50 -08:00
gerrit-util-ssl Remove unused .gitignore 2013-11-28 22:56:51 -08:00
gerrit-war Bump Jetty version to stable 9.1 and Servlet API to 3.1 2014-01-04 22:28:10 +01:00
lib Only pack CM3 themes selectable by the user 2014-01-21 15:07:10 -08:00
plugins Update plugins to latest revisions 2014-01-17 18:05:32 +09:00
ReleaseNotes Correct --recheck-mergeable flag in 2.9 release notes 2014-01-22 19:22:12 +09:00
tools Buck: Decouple plugin-api installation from deployment 2014-01-20 00:28:47 +00:00
website/releases Update release website index to use new documentation site 2013-10-17 17:07:30 +09:00
.buckconfig Cache buck build results locally by default 2013-12-11 13:21:39 +01:00
.buckversion Update Buck 2013-11-29 10:50:59 -08:00
.gitignore Update Buck 2013-11-29 10:50:59 -08:00
.gitmodules Add singleusergroup plugin 2013-11-09 07:45:00 +01:00
.pydevproject Set python version back to 2.6.5 in .pydevproject 2013-05-20 11:36:08 +09:00
BUCK Buck: generate javadocs for plugin and extension API 2013-11-24 02:04:51 +01:00
COPYING Initial project setup of Gerrit 2 2008-11-14 16:59:34 -08:00
INSTALL Remove Gerrit 1.x to 2.x import tools 2009-03-27 20:20:10 -07:00
SUBMITTING_PATCHES Update push URL in SUBMITTING_PATCHES 2012-03-29 00:57:14 -04:00
VERSION Merge branch 'stable-2.8' 2014-01-15 11:47:53 +09:00