Files
gerrit/polygerrit-ui/app/elements/diff/gr-diff-preferences-dialog/gr-diff-preferences-dialog.js
brohlfs 3e7f5fdd3f Polymer 2: Add _legacyUndefinedCheck
When legacy-data-mixin.html is imported this will tell you on the console which observers need fixing regarding this change of behavior:

https://polymer-library.polymer-project.org/2.0/docs/upgrade#update-observers

This change was created by running this command line:

find polygerrit-ui/app/ -type f | xargs sed -i '/^    is: / a\    _legacyUndefinedCheck: true,'

Once all observers are fixed, this change will be reverted. This is tracked in https://bugs.chromium.org/p/gerrit/issues/detail?id=10723

Change-Id: Icccdfaa52bf77dfb25e949b2aa2402110f6c2276
2019-04-17 13:15:50 +00:00

68 lines
1.6 KiB
JavaScript

/**
* @license
* Copyright (C) 2019 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
(function() {
'use strict';
Polymer({
is: 'gr-diff-preferences-dialog',
_legacyUndefinedCheck: true,
properties: {
/** @type {?} */
diffPrefs: Object,
_diffPrefsChanged: Boolean,
},
getFocusStops() {
return {
start: this.$.contextSelect,
end: this.$.saveButton,
};
},
resetFocus() {
this.$.contextSelect.focus();
},
_computeHeaderClass(changed) {
return changed ? 'edited' : '';
},
_handleCancelDiff(e) {
e.stopPropagation();
this.$.diffPrefsOverlay.close();
},
open() {
this.$.diffPrefsOverlay.open().then(() => {
const focusStops = this.getFocusStops();
this.$.diffPrefsOverlay.setFocusStops(focusStops);
this.resetFocus();
});
},
_handleSaveDiffPreferences() {
this.$.diffPreferences.save().then(() => {
this.fire('reload-diff-preference', null, {bubbles: false});
this.$.diffPrefsOverlay.close();
});
},
});
})();