341baf22a0
ChangeData currently loads the change directly from the database, but now when we support notedb it should load the change via the change notes factory. Loading the change via the change notes factory requires the project name in addition to the change ID, hence ChangeData must know it. The only caller of ChangeData that cannot provide the project name is HasDraftByLegacyPredicate. Due to this HasDraftByLegacyPredicate loads the changes on its own from the database for now. We may remove this deprecated predicate before migrating to notedb or find another solution later. When the change is now loaded from notedb its last modified timestamp is only precise to seconds, while when its loaded from the database it is precise to milliseconds. Due to this different changes got the same last modified timestamp when notedb was enabled and as result the GetRelatedIT#getRelatedReworkThenExtendInTheMiddleOfSeries test started to fail. Defining a 1s time clock step for this test fixes this issue. Change-Id: Iee0dce795766f543c996d75fde4067cb23a357dd Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit Code Review
Gerrit is a code review and project management tool for Git based projects.
Objective
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
Documentation
For information about how to install and use Gerrit, refer to the documentation.
Source
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Reporting bugs
Please report bugs on the issue tracker.
Contribute
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
Getting in contact
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
License
Gerrit is provided under the Apache License 2.0.
Build
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
Install binary packages (Deb/Rpm)
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.
Events
- March 14-18 2016: Gerrit Hackathon, Berlin (free seats are still available).