4bf1608967
PrologRuleEvaluator#evaluate() is only used from PrologRule#evaluate(ChangeData, SubmitRuleOptions) which implements the SubmitRule interface. SubmitRules are only invoked from SubmitRuleEvaluator. SubmitRuleEvaluator checks the change state and whether closed changes are allowed before invoking the submit rules. If closed changes are not allowed and the change is closed SubmitRuleEvaluator returns a submit record with status SubmitRecord.Status.CLOSED and the submit rules are not invoked. This means PrologRuleEvaluator#evaluate() doesn't need to the same check again as it is never invoked if this is the case. If this check would be needed all other implementations of SubmitRule would need to do the same, but none of them does. This is part of an effort to eliminate the passing of SubmitRuleOptions into the submit rules. The SubmitRuleOptions contain mostly Prolog-specific settings and are only used by the PrologRule. All other implementation of SubmitRule ignore the options, hence it would be cleaner to remove them from the SubmitRule interface. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I453b575b6aaf22b335cd3d7fa89df662208abf3b
Gerrit Code Review
Gerrit is a code review and project management tool for Git based projects.
Objective
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
Documentation
For information about how to install and use Gerrit, refer to the documentation.
Source
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Reporting bugs
Please report bugs on the issue tracker.
Contribute
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
Getting in contact
The Developer Mailing list is repo-discuss on Google Groups.
License
Gerrit is provided under the Apache License 2.0.
Build
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
Install binary packages (Deb/Rpm)
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Use pre-built Gerrit images on Docker
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.