5a5bd9ae66
This is a partial revert of 903be04b02.
With the NoteDb migration ChangeFinder is querying the secondary
index to map from Change.Id to verify a change exists and locate
the project the change's metadata is stored in. If a change is not
found in the secondary index there is no need to delete the change,
as it does not exist in the secondary index.
Some secondary index implementations (notably the one at Google
behind gerrit-review) implement delete by appending a negative
assertion into the index, stating the document does not exist.
Each failed lookup appends more negative assertions into the index,
which can cause problems when there is replication delay between
multi-master instances.
Stop sending delete calls to the secondary index when ChangeFinder
got no results. Leave the index alone. The parse() methods are
typically invoked by GET calls, which should not be modifying
server state.
Change-Id: Iafd89324f9945dd827c37fec2d2ac54b89fc4e4a
Gerrit Code Review
Gerrit is a code review and project management tool for Git based projects.
Objective
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
Documentation
For information about how to install and use Gerrit, refer to the documentation.
Source
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Reporting bugs
Please report bugs on the issue tracker.
Contribute
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
Getting in contact
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
License
Gerrit is provided under the Apache License 2.0.
Build
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
Install binary packages (Deb/Rpm)
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.
Events
- March 14-18 2016: Gerrit Hackathon, Berlin (free seats are still available).