opendev/gerrit
Code Issues Proposed changes
RETIRED, Gerrit as used by OpenStack
10,551 Commits 1 Branch 360 Tags 120 MiB
5ac379ca64
Go to file
Shawn Pearce 5ac379ca64 Try to avoid null group UUIDs in transitive include processing 
One of our production Gerrit instances is seeing null UUIDs in the
group backend code, leading to NPEs from the IncludingGroupMembership
code paths. We presently have no idea how the null UUID is being
added into the group collection.

Guard the internal group listing for an AccountState to avoid
groups that are missing a UUID. Also ensure the queue does not get
initialized with a null entry, and never add a null UUID during
iteration. This should stop the NPE we are seeing in our logs,
but is probably only a bandaid over the real source of the null.

Change-Id: I61543cbf71f62aa42d1188818e1296020497e4a3
2014-02-04 15:18:30 -08:00
.settings Eclipse: Bump java source and target level to 7 2013-11-29 00:15:50 +01:00
contrib Add contrib/ui-api-proxy.go for testing UI features with live data. 2013-12-18 09:07:02 -08:00
Documentation Add 'del' as alias for 'delete' in JavaScript API 2014-02-03 17:56:39 +01:00
gerrit-acceptance-tests Merge branch 'stable-2.8' 2014-02-04 14:10:20 -08:00
gerrit-antlr Remove unused .gitignore 2013-11-28 22:56:51 -08:00
gerrit-cache-h2 Merge "Remove unused @SuppressWarnings" 2013-11-29 08:08:53 +00:00
gerrit-common SubmitRecord: Add equals and hashCode methods 2014-01-30 15:14:41 -08:00
gerrit-extension-api Fix javadoc unresolved link warning 2014-02-01 15:11:51 +01:00
gerrit-gwtdebug Update GWT version to 2.6.0-rc3 2014-01-23 06:39:08 +01:00
gerrit-gwtexpui Replace gwt.user.client.Element with gwt.dom.client.Element 2014-01-24 16:54:24 +09:00
gerrit-gwtui Merge "Allow URL parameters for extension screens" 2014-02-04 10:32:11 +00:00
gerrit-httpd Merge "Add extension point for receive-pack initialization." 2014-01-31 22:32:39 +00:00
gerrit-launcher Clarify that GerritLauncher must be a self-contained class 2014-02-04 14:48:26 -08:00
gerrit-lucene Eliminate potential NPEs with ChangeData.getChange() 2014-01-03 09:10:45 -08:00
gerrit-main Build Main for Java 1.2 2013-11-30 01:53:00 -08:00
gerrit-openid Bump Jetty version to stable 9.1 and Servlet API to 3.1 2014-01-04 22:28:10 +01:00
gerrit-patch-commonsnet Replace 'for' loop with 'foreach' 2013-12-04 01:02:53 +04:00
gerrit-patch-jgit Apply "type inference for generic instance creation" Java 7 feature 2014-01-25 17:51:08 +01:00
gerrit-pgm Define module for having group related Guice bindings in one place 2014-01-17 15:06:05 +00:00
gerrit-plugin-api Bump Jetty version to stable 9.1 and Servlet API to 3.1 2014-01-04 22:28:10 +01:00
gerrit-plugin-archetype Update year to 2014 in license headers of plugin archetype resources 2014-01-28 16:09:15 +01:00
gerrit-plugin-gwt-archetype Change GWT plugin archetype to implement screen instead of dialog 2014-01-28 20:51:09 +01:00
gerrit-plugin-gwtui Add 'del' as alias for 'delete' in JavaScript API 2014-02-03 17:56:39 +01:00
gerrit-plugin-js-archetype Update year to 2014 in license headers of plugin archetype resources 2014-01-28 16:09:15 +01:00
gerrit-prettify Save GWT compile time by avoiding javac 2013-11-30 11:06:50 -08:00
gerrit-reviewdb Add tests for LabelNormalizer 2014-01-31 15:50:01 -08:00
gerrit-server Try to avoid null group UUIDs in transitive include processing 2014-02-04 15:18:30 -08:00
gerrit-solr Eliminate potential NPEs with ChangeData.getChange() 2014-01-03 09:10:45 -08:00
gerrit-sshd Merge branch 'stable-2.8' 2014-02-04 14:10:20 -08:00
gerrit-util-cli Save GWT compile time by avoiding javac 2013-11-30 11:06:50 -08:00
gerrit-util-ssl Remove unused .gitignore 2013-11-28 22:56:51 -08:00
gerrit-war Bump Jetty version to stable 9.1 and Servlet API to 3.1 2014-01-04 22:28:10 +01:00
lib Upgrade guava to 16.0 2014-01-30 20:28:00 +00:00
plugins Update replication plugin to latest revision 2014-01-30 10:37:03 +09:00
ReleaseNotes Merge branch 'stable-2.8' 2014-02-04 14:10:20 -08:00
tools Fix build 2014-01-31 18:27:09 +01:00
website/releases Update release website index to use new documentation site 2013-10-17 17:07:30 +09:00
.buckconfig Cache buck build results locally by default 2013-12-11 13:21:39 +01:00
.buckversion Update Buck 2013-11-29 10:50:59 -08:00
.gitignore Update Buck 2013-11-29 10:50:59 -08:00
.gitmodules Add singleusergroup plugin 2013-11-09 07:45:00 +01:00
.pydevproject Set python version back to 2.6.5 in .pydevproject 2013-05-20 11:36:08 +09:00
BUCK Buck: generate javadocs for plugin and extension API 2013-11-24 02:04:51 +01:00
COPYING Initial project setup of Gerrit 2 2008-11-14 16:59:34 -08:00
INSTALL Remove Gerrit 1.x to 2.x import tools 2009-03-27 20:20:10 -07:00
SUBMITTING_PATCHES Update push URL in SUBMITTING_PATCHES 2012-03-29 00:57:14 -04:00
VERSION Merge branch 'stable-2.8' 2014-01-15 11:47:53 +09:00