opendev/gerrit
Code Issues Proposed changes
RETIRED, Gerrit as used by OpenStack
11,166 Commits 1 Branch 360 Tags 120 MiB
5f10081645
Go to file
David Pursehouse 5f10081645 ChangeUpdate: fix comparison of Change.Id to Change.Key 
Fix comparison of Change.Id to Change.Key in ChangeUpdate.

Commit 6761264d08 already fixed the
same problem in ChangeInserter.

Both problems were being reported by FindBugs:

  Call to com.google.gerrit.reviewdb.client.Change$Id.equals(
  com.google.gerrit.reviewdb.client.Change$Key) in
  com.google.gerrit.server.notedb.ChangeUpdate.setPatchSetId(
  PatchSet$Id)

  This method calls equals(Object) on two references of different
  class types with no common subclasses. Therefore, the objects
  being compared are unlikely to be members of the same class at
  runtime (unless some application classes were not analyzed, or
  dynamic class loading can occur at runtime). According to the
  contract of equals(), objects of different classes should always
  compare as unequal; therefore, according to the contract defined
  by java.lang.Object.equals(Object), the result of this comparison
  will always be false at runtime.

Change-Id: I75f833d1c19f83abdddd765010416d5de6fffec3
2014-06-30 09:03:15 +00:00
.settings Eclipse: Bump java source and target level to 7 2013-11-29 00:15:50 +01:00
contrib Allow to download reposize.sh script from Gerrit 2014-05-09 16:20:51 +02:00
Documentation Docs: changes /index endpoint requires administrateServer capability 2014-06-27 14:56:42 +00:00
gerrit-acceptance-tests Limit file list to files that were touched in new patch set 2014-05-20 05:39:55 +02:00
gerrit-antlr Remove unused .gitignore 2013-11-28 22:56:51 -08:00
gerrit-cache-h2 Merge "Remove unused @SuppressWarnings" 2013-11-29 08:08:53 +00:00
gerrit-common Add 'View Plugins' global capability that allows to list plugins 2014-05-09 19:51:00 +02:00
gerrit-extension-api Add pom with meta-data for plugin projects 2014-05-21 16:24:39 +02:00
gerrit-gwtdebug Prevent StackOverflowError in JettyTreeLogger 2014-02-07 12:54:18 +00:00
gerrit-gwtexpui Change CopyableLabel to hide onKeyUp 2014-05-12 18:08:56 -05:00
gerrit-gwtui ChangeScreen2: Respect user preference for unified diff view 2014-06-03 15:05:54 +02:00
gerrit-gwtui-common Introduce Gerrit gwtui common project 2014-02-17 22:54:00 +01:00
gerrit-httpd Fix the request wrapper for http requests served from plugins 2014-05-15 14:45:17 +02:00
gerrit-launcher Use public getter to retrieve name from JarFile 2014-03-18 23:16:35 +01:00
gerrit-lucene Merge branch 'stable-2.8' into stable-2.9 2014-04-14 12:10:34 -07:00
gerrit-main Build Main for Java 1.2 2013-11-30 01:53:00 -08:00
gerrit-openid Bump Jetty version to stable 9.1 and Servlet API to 3.1 2014-01-04 22:28:10 +01:00
gerrit-patch-commonsnet Replace 'for' loop with 'foreach' 2013-12-04 01:02:53 +04:00
gerrit-patch-jgit Apply "type inference for generic instance creation" Java 7 feature 2014-01-25 17:51:08 +01:00
gerrit-pgm Reindex: Include exception cause when dying 2014-05-16 00:30:43 +00:00
gerrit-plugin-api Add pom with meta-data for plugin projects 2014-05-21 16:24:39 +02:00
gerrit-plugin-archetype Bump API version to 2.8.6 2014-06-25 11:16:34 +02:00
gerrit-plugin-gwt-archetype Bump API version to 2.8.6 2014-06-25 11:16:34 +02:00
gerrit-plugin-gwtui Bump API version to 2.8.6 2014-06-25 11:16:34 +02:00
gerrit-plugin-js-archetype Bump API version to 2.8.6 2014-06-25 11:16:34 +02:00
gerrit-prettify Correct fix for potential NPE in PrettyFormatter 2014-03-04 11:14:56 +01:00
gerrit-reviewdb MergeabilityChecker: Fix isStale() optimization 2014-06-14 15:25:20 +02:00
gerrit-server ChangeUpdate: fix comparison of Change.Id to Change.Key 2014-06-30 09:03:15 +00:00
gerrit-solr Merge changes Iac79af54,Ief41eccc,Iae52ade9,I0bd9eabb,I2ef5b9e1 2014-02-13 17:02:23 +00:00
gerrit-sshd Remove unnecessary @SuppressWarnings("unchecked") 2014-04-30 17:38:01 +09:00
gerrit-util-cli Save GWT compile time by avoiding javac 2013-11-30 11:06:50 -08:00
gerrit-util-ssl Remove unused .gitignore 2013-11-28 22:56:51 -08:00
gerrit-war Buck: Deploy plugin artifacts to Maven Central 2014-05-26 22:06:42 +02:00
lib Upgrade gwtorm to 1.11 2014-05-26 17:14:00 +02:00
plugins Update replication plugin 2014-06-13 10:45:30 +09:00
ReleaseNotes Update 2.9 release notes to mention fixes from 2.8.6 2014-06-27 10:15:28 +00:00
tools Bash: Deploy plugin archetypes to Maven Central 2014-05-26 23:44:40 +02:00
website/releases Exclude gerrit-snapshot-* from releases page 2014-02-19 05:56:00 +00:00
.buckconfig Move gerrit.war from api_{install,deploy} to war_{install,deploy} 2014-05-20 06:41:08 +00:00
.buckversion Update Buck 2013-11-29 10:50:59 -08:00
.gitignore Buck: Deploy plugin artifacts to Maven Central 2014-05-26 22:06:42 +02:00
.gitmodules Add singleusergroup plugin 2013-11-09 07:45:00 +01:00
.pydevproject Set python version back to 2.6.5 in .pydevproject 2013-05-20 11:36:08 +09:00
BUCK Merge branch 'stable-2.8' into stable-2.9 2014-05-01 12:44:01 -07:00
COPYING Initial project setup of Gerrit 2 2008-11-14 16:59:34 -08:00
INSTALL Remove Gerrit 1.x to 2.x import tools 2009-03-27 20:20:10 -07:00
SUBMITTING_PATCHES Update push URL in SUBMITTING_PATCHES 2012-03-29 00:57:14 -04:00
VERSION Merge branch 'stable-2.8' into stable-2.9 2014-06-25 20:42:42 +09:00