e82c8405ef
Formerly the comment links were provided to the formatted text elements via a stale property, resulting in links not appearing in the reply dialog drafts. With this change the binding is updated, the stale property is removed and a test is added. Bug: Issue 7713 Change-Id: Ic07b4f1833ebf82ea0524ba3318080dc7759d194
99 lines
3.0 KiB
HTML
99 lines
3.0 KiB
HTML
<!DOCTYPE html>
|
|
<!--
|
|
Copyright (C) 2016 The Android Open Source Project
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
-->
|
|
|
|
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
|
|
<title>gr-comment-list</title>
|
|
|
|
<script src="../../../bower_components/webcomponentsjs/webcomponents-lite.min.js"></script>
|
|
<script src="../../../bower_components/web-component-tester/browser.js"></script>
|
|
<link rel="import" href="../../../test/common-test-setup.html"/>
|
|
<link rel="import" href="gr-comment-list.html">
|
|
|
|
<script>void(0);</script>
|
|
|
|
<test-fixture id="basic">
|
|
<template>
|
|
<gr-comment-list></gr-comment-list>
|
|
</template>
|
|
</test-fixture>
|
|
|
|
<script>
|
|
suite('gr-comment-list tests', () => {
|
|
let element;
|
|
|
|
setup(() => {
|
|
element = fixture('basic');
|
|
});
|
|
|
|
test('_computeFilesFromComments w/ special file path sorting', () => {
|
|
const comments = {
|
|
'file_b.html': [],
|
|
'file_c.css': [],
|
|
'file_a.js': [],
|
|
'test.cc': [],
|
|
'test.h': [],
|
|
};
|
|
const expected = [
|
|
'file_a.js',
|
|
'file_b.html',
|
|
'file_c.css',
|
|
'test.h',
|
|
'test.cc',
|
|
];
|
|
const actual = element._computeFilesFromComments(comments);
|
|
assert.deepEqual(actual, expected);
|
|
|
|
assert.deepEqual(element._computeFilesFromComments(null), []);
|
|
});
|
|
|
|
test('_computePatchDisplayName', () => {
|
|
const comment = {line: 123, side: 'REVISION', patch_set: 10};
|
|
|
|
element.patchNum = 10;
|
|
assert.equal(element._computePatchDisplayName(comment), '');
|
|
|
|
element.patchNum = 9;
|
|
assert.equal(element._computePatchDisplayName(comment), 'PS10, ');
|
|
|
|
comment.side = 'PARENT';
|
|
assert.equal(element._computePatchDisplayName(comment), 'Base, ');
|
|
});
|
|
|
|
test('config commentlinks propagate to formatted text', () => {
|
|
element.comments = {
|
|
'test.h': [{
|
|
author: {name: 'foo'},
|
|
patch_set: 4,
|
|
line: 10,
|
|
updated: '2017-10-30 20:48:40.000000000',
|
|
message: 'Ideadbeefdeadbeef',
|
|
unresolved: true,
|
|
}],
|
|
};
|
|
element.projectConfig = {
|
|
commentlinks: {foo: {link: '#/q/$1', match: '(I[0-9a-f]{8,40})'}},
|
|
};
|
|
flushAsynchronousOperations();
|
|
const formattedText = Polymer.dom(element.root).querySelector(
|
|
'gr-formatted-text.message');
|
|
assert.isOk(formattedText.config);
|
|
assert.deepEqual(formattedText.config,
|
|
element.projectConfig.commentlinks);
|
|
});
|
|
});
|
|
</script>
|