783c5a5516
Gerrit slaves are read-only and hence pushing to them is disabled. Pushes over SSH come in as git-receive-pack commands. For slaves this command is mapped to an SSH Command class that fails immediately so that pushes on slaves are disabled. This SSH Command class is also supposed to provide a meaningful error message to the client (see change Ia25012486b). However this didn't work: 1. A git-receive-pack command has the project name to which the push is done as argument: The SSH Command class that was bound for git-receive-pack commands on slaves didn't allow any argument. Hence the request already failed during the command parsing so that the bound SSH Command class was not executed. 2. When using JGit on client-side the exception message from the server didn't reach the client. On client side the error was always "Short read of block". Then the client checked whether the remote repository exists by fetching from it. For slaves this fetch works and then JGit returned "push not permitted" as error message to the callers. To fix 1 the SSH Command class that is bound for git-receive-pack commands on slaves now extends AbstractGitCommand which defines the argument for the project name. To fix 2 we write out a special ERR packet which allows to pass a customized remote service error to the client. The error message that we return from slaves when pushing is now consistent between SSH and HTTP. In both cases we now throw a ServiceNotEnabledException. Change-Id: Id99e93d0127d58114b54b4deea7f5227b920c8e2 Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit Code Review
Gerrit is a code review and project management tool for Git based projects.
Objective
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
Documentation
For information about how to install and use Gerrit, refer to the documentation.
Source
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Reporting bugs
Please report bugs on the issue tracker.
Contribute
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
Getting in contact
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
License
Gerrit is provided under the Apache License 2.0.
Build
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
Install binary packages (Deb/Rpm)
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Use pre-built Gerrit images on Docker
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.