8079bb0882
We were hard-coding patch set 1 and only including the Branch and Change-id footers in the ChangeUpdate for this change. However, if PS1 of a change was a deleted draft, then this patch set won't be in ReviewDb, so we would never write those footers. That results in an exception during rebuilding like: com.google.gwtorm.server.OrmException: org.eclipse.jgit.errors.ConfigInvalidException: Change 64: Missing footers: Branch, Change-id at com.google.gerrit.server.notedb.AbstractChangeNotes.load(AbstractChangeNotes.java:134) Instead, keep track of the earliest patch set that we actually have for a change, and record the mandatory footers in the update for that change. This issue only applies to rebuilding changes from ReviewDb, as patch set deletion in native NoteDb happens by adding tombstone records, and does not affect the root commit in the change meta graph. Add tests for deleting a subset of patch sets to DeleteDraftPatchSetIT to get some coverage for this case. Bug: Issue 4084 Change-Id: I36da735cabc9a5eddbda0a55c086027c0b2ad031
Gerrit Code Review
Gerrit is a code review and project management tool for Git based projects.
Objective
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
Documentation
For information about how to install and use Gerrit, refer to the documentation.
Source
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Reporting bugs
Please report bugs on the issue tracker.
Contribute
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
Getting in contact
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
License
Gerrit is provided under the Apache License 2.0.
Build
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
Install binary packages (Deb/Rpm)
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.