80f2ab6255
We want to be able to deduplicate PermissionBackendConditions when given a list of such objects. Therefore, this commit implements equals() and hashCode(). This is not trivial since the individual implementations of PermissionBackendCondition encapsulate a CurrentUser as well as a PermissionBackend. Both of which do not implement equals() and hashCode(). This is correct, since PermissionBackend is a service and comparing it to other PermissionBackends makes no sense. CurrentUser could be compared to other CurrentUser objects but the outcome depends on wheather two annonymous users should be considered equal or not. This depends on the use case. Therefore, this commit adds user() and resourcePath() to PermissionBackend to get the entities that a PermissionBackend object is scoped to and evaluate the case at hand directly in PermissionBackendCondition. resourcePath() can come in handy in other places as well since it is an accurate representation of the resource that we are performing checks on. Concrete PermissionBackend implementations can use it to communicate with their remove service if desired. The implementation for resourcePath() picks /+ as the delimiter since it is a forbidden character combination for project names. An alternative would be to URL-encode the project name, but this is more expensive. Change-Id: I7b357e61bfc6f14acc7b0d06830b615847798ec3
Gerrit Code Review
Gerrit is a code review and project management tool for Git based projects.
Objective
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
Documentation
For information about how to install and use Gerrit, refer to the documentation.
Source
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Reporting bugs
Please report bugs on the issue tracker.
Contribute
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
Getting in contact
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
License
Gerrit is provided under the Apache License 2.0.
Build
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
Install binary packages (Deb/Rpm)
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Use pre-built Gerrit images on Docker
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.