opendev
/
gerrit
Code Issues Proposed changes
gerrit/gerrit-server/src/main/java/com/google/gerrit/server/change
History
Dave Borowitz 7f2991dc13 Skip migrating inline comments on missing patch set parents 
In NoteDb, inline comments are stored on notes referring to the commit
containing that file. For a comment on the PARENT side of a patch set,
the migration process needs to look up the parent SHA-1; this lookup
will fail if the patch set SHA-1 is missing. The changes can be
otherwise migrated, although of course they may fail to render or
present other problems down the line.

This fix is slightly invasive because it changes the signature of
CommentsUtil#setCommentRevId to throw PatchListNotAvailableException,
allowing the downstream migration code to distinguish this case.

Bug: Issue 8552
Change-Id: I9bcd4f533f02fa20617d5c0b2b3264a8899e9f2c
 		2018-03-16 13:44:25 -04:00
..
Abandon.java Discontinue draft workflow 2017-09-30 15:47:14 +02:00
AbandonUtil.java Abandon: Use ChangeData instead of ChangeControl 2017-09-11 10:34:51 +02:00
AccountPatchReviewStore.java Merge branch 'stable-2.13' into stable-2.14 2017-04-25 12:31:40 +02:00
ActionJson.java Discontinue draft workflow 2017-09-30 15:47:14 +02:00
AllowedFormats.java Format all Java files with google-java-format 2017-02-07 10:04:39 +09:00
ApplyFix.java Remove ChangeResource#getControl() and migrate callers 2017-09-13 09:37:26 +02:00
ArchiveFormat.java ArchiveFormat: Don't use deprecated ArchiveCommand.Format#putEntry 2017-03-24 09:06:24 +09:00
ChangeCleanupRunner.java Convert ChangeCleanupRunner to RetryHelper 2017-05-15 11:01:05 -04:00
ChangeEditResource.java Reduce usage of ChangeControl 2017-08-29 11:05:03 +02:00
ChangeEdits.java Make ChangeControl package-private 2018-02-24 12:25:41 +01:00
ChangeIncludedIn.java Reduce usage of ChangeControl 2017-08-29 11:05:03 +02:00
ChangeInserter.java Discontinue draft workflow 2017-09-30 15:47:14 +02:00
ChangeJson.java Make ChangeControl package-private 2018-02-24 12:25:41 +01:00
ChangeKindCache.java MergeUtil: Don't pass Repository to newMerger 2017-04-07 11:56:59 -04:00
ChangeKindCacheImpl.java Change kind cache: short-circuit on root commits 2018-03-16 00:23:48 +00:00
ChangeMessages.java Update Set Review API to behave in line with RFC 7231 2017-04-27 09:16:24 +02:00
ChangeResource.java Upgrade Guava to 22.0 2017-11-02 19:10:14 +00:00
ChangeTriplet.java Cleanup ChangeFinder parsing logic 2017-07-02 15:29:43 -07:00
ChangesCollection.java Correct use of generics in AcceptsPost#post 2017-09-14 13:51:05 +02:00
Check.java Remove ChangeResource#getControl() and migrate callers 2017-09-13 09:37:26 +02:00
CherryPick.java Factor out Contributor Agreements from ProjectControl 2017-10-01 14:14:41 +00:00
CherryPickChange.java Discontinue draft workflow 2017-09-30 15:47:14 +02:00
CherryPickCommit.java Factor out Contributor Agreements from ProjectControl 2017-10-01 14:14:41 +00:00
CommentJson.java Conistently import Collectors.* statically 2017-03-02 10:27:43 +01:00
CommentResource.java Support to delete a comment with 'NoteDbRewriter' in BatchUpdate 2017-05-09 21:56:26 +02:00
Comments.java Format all Java files with google-java-format 2017-02-07 10:04:39 +09:00
ConsistencyChecker.java ConsistencyChecker: Replace ChangeControl with ChangeNotes 2017-09-15 10:45:27 +02:00
CreateChange.java Merge "Add config to disable private changes" into stable-2.15 2018-02-08 13:29:49 +00:00
CreateDraftComment.java Skip migrating inline comments on missing patch set parents 2018-03-16 13:44:25 -04:00
CreateMergePatchSet.java Discontinue draft workflow 2017-09-30 15:47:14 +02:00
DeleteAssignee.java Convert most ChangeApi handlers to retrying wrappers 2017-05-04 12:53:40 -04:00
DeleteChange.java Discontinue draft workflow 2017-09-30 15:47:14 +02:00
DeleteChangeEdit.java Reduce usage of ChangeControl 2017-08-29 11:05:03 +02:00
DeleteChangeOp.java Remove handling of change.allowDrafts 2018-02-21 14:26:23 +00:00
DeleteComment.java Convert DeleteComment to RetryHelper 2017-05-15 11:01:05 -04:00
DeleteDraftComment.java Skip migrating inline comments on missing patch set parents 2018-03-16 13:44:25 -04:00
DeletePrivate.java Private state changed event 2017-12-19 17:36:54 +01:00
DeletePrivateByPost.java Private state changed event 2017-12-19 17:36:54 +01:00
DeleteReviewer.java Downgrade notify for WIP reviewer deletion 2017-06-14 14:13:30 -07:00
DeleteReviewerByEmailOp.java Downgrade notify for WIP reviewer deletion 2017-06-14 14:13:30 -07:00
DeleteReviewerOp.java Make ChangeControl package-private 2018-02-24 12:25:41 +01:00
DeleteVote.java Make ChangeControl package-private 2018-02-24 12:25:41 +01:00
DownloadContent.java Remove ChangeResource#getControl() and migrate callers 2017-09-13 09:37:26 +02:00
DraftCommentResource.java Remove ChangeResource#getControl() and migrate callers 2017-09-13 09:37:26 +02:00
DraftComments.java Format all Java files with google-java-format 2017-02-07 10:04:39 +09:00
EmailReviewComments.java Clarify arguments to EmailReviewComments.Factory 2017-04-28 12:32:48 -04:00
FileContentUtil.java Upgrade Guava to 22.0 2017-11-02 19:10:14 +00:00
FileInfoJson.java Fix bug in computation of hunks due to rebase 2017-06-14 17:19:37 +02:00
FileResource.java Allow public access to classes and methods 2015-05-03 22:09:06 -07:00
Files.java Make ChangeControl package-private 2018-02-24 12:25:41 +01:00
FixResource.java Add REST endpoint to apply a suggested fix of a robot comment 2017-03-23 09:49:46 +01:00
Fixes.java Add REST endpoint to apply a suggested fix of a robot comment 2017-03-23 09:49:46 +01:00
GetArchive.java Remove ChangeResource#getControl() and migrate callers 2017-09-13 09:37:26 +02:00
GetAssignee.java Format all Java files with google-java-format 2017-02-07 10:04:39 +09:00
GetBlame.java Update Gitiles blame_cache to v0.2-3 2017-08-28 13:09:56 -07:00
GetChange.java Format all Java files with google-java-format 2017-02-07 10:04:39 +09:00
GetComment.java Add support for Robot Comments 2016-09-28 15:34:54 +02:00
GetCommit.java Remove ChangeResource#getControl() and migrate callers 2017-09-13 09:37:26 +02:00
GetContent.java Remove ChangeResource#getControl() and migrate callers 2017-09-13 09:37:26 +02:00
GetDescription.java Add patch set description api endpoints 2016-11-17 13:27:56 -08:00
GetDetail.java Format all Java files with google-java-format 2017-02-07 10:04:39 +09:00
GetDiff.java Make ChangeControl package-private 2018-02-24 12:25:41 +01:00
GetDraftComment.java Add support for Robot Comments 2016-09-28 15:34:54 +02:00
GetHashtags.java Reduce usage of ChangeControl 2017-08-29 11:05:03 +02:00
GetMergeList.java Remove ChangeResource#getControl() and migrate callers 2017-09-13 09:37:26 +02:00
GetPastAssignees.java Reduce usage of ChangeControl 2017-08-29 11:05:03 +02:00
GetPatch.java Remove ChangeResource#getControl() and migrate callers 2017-09-13 09:37:26 +02:00
GetPureRevert.java Make ChangeControl package-private 2018-02-24 12:25:41 +01:00
GetRelated.java Make ChangeControl package-private 2018-02-24 12:25:41 +01:00
GetReview.java Extensions GWT API: Align rule with package boundaries 2015-01-26 09:26:57 +00:00
GetReviewer.java Test permitted labels with PermissionBackend 2017-04-14 13:32:32 +09:00
GetRevisionActions.java Upgrade Guava to 22.0 2017-11-02 19:10:14 +00:00
GetRobotComment.java Format all Java files with google-java-format 2017-02-07 10:04:39 +09:00
GetTopic.java ChangeApi: Implement get/put topic 2014-08-13 08:24:18 -07:00
HashtagsUtil.java Reject invalid hashtags with 400 Bad Request 2017-09-19 09:37:31 +02:00
Ignore.java Make IllegalLabelException a checked Exception 2017-09-18 17:07:12 +02:00
IncludedIn.java Format all Java files with google-java-format 2017-02-07 10:04:39 +09:00
IncludedInResolver.java Rename IncludedInResolver.includedInOne() to #includedInAny 2017-08-02 11:49:55 +02:00
Index.java Convert most ChangeApi handlers to retrying wrappers 2017-05-04 12:53:40 -04:00
LimitedByteArrayOutputStream.java Format all Java files with google-java-format 2017-02-07 10:04:39 +09:00
ListChangeComments.java Reduce usage of ChangeControl 2017-08-29 11:05:03 +02:00
ListChangeDrafts.java Reduce usage of ChangeControl 2017-08-29 11:05:03 +02:00
ListChangeRobotComments.java Reduce usage of ChangeControl 2017-08-29 11:05:03 +02:00
ListReviewers.java Test permitted labels with PermissionBackend 2017-04-14 13:32:32 +09:00
ListRevisionComments.java Format all Java files with google-java-format 2017-02-07 10:04:39 +09:00
ListRevisionDrafts.java Format all Java files with google-java-format 2017-02-07 10:04:39 +09:00
ListRevisionReviewers.java Test permitted labels with PermissionBackend 2017-04-14 13:32:32 +09:00
ListRobotComments.java Format all Java files with google-java-format 2017-02-07 10:04:39 +09:00
MarkAsReviewed.java Replace Mute/Unmute by Mark as Reviewed/Unreviewed (Part 1) 2017-10-01 14:34:40 +02:00
MarkAsUnreviewed.java Replace Mute/Unmute by Mark as Reviewed/Unreviewed (Part 1) 2017-10-01 14:34:40 +02:00
MergeabilityCache.java Format all Java files with google-java-format 2017-02-07 10:04:39 +09:00
MergeabilityCacheImpl.java Callable: Replace classes with lambda expression 2017-04-01 21:47:49 +02:00
Mergeable.java Remove ChangeControl from ChangeData 2017-09-25 13:42:07 +02:00
Module.java Private state changed event 2017-12-19 17:36:54 +01:00
Move.java Extract an enum for label functions 2018-02-21 08:27:32 -05:00
NotifyUtil.java Remove unused ReviewDb from AccountResolver 2017-10-01 13:27:49 +01:00
PatchSetInserter.java Discontinue draft workflow 2017-09-30 15:47:14 +02:00
PostHashtags.java Reduce usage of ChangeControl 2017-08-29 11:05:03 +02:00
PostPrivate.java Add config to disable private changes 2018-02-06 13:44:31 +00:00
PostReview.java Skip migrating inline comments on missing patch set parents 2018-03-16 13:44:25 -04:00
PostReviewers.java Fix "Group members can't be added as reviewers" after merging 2018-03-14 22:17:12 +09:00
PostReviewersOp.java Move ChangeControl#getLabelTypes() to ProjectState and migrate callers 2017-08-30 17:20:16 +02:00
PreviewSubmit.java Remove ChangeResource#getControl() and migrate callers 2017-09-13 09:37:26 +02:00
PublishChangeEdit.java Factor out Contributor Agreements from ProjectControl 2017-10-01 14:14:41 +00:00
PutAssignee.java Reduce usage of ChangeControl 2017-08-29 11:05:03 +02:00
PutDescription.java Remove ChangeResource#getControl() and migrate callers 2017-09-13 09:37:26 +02:00
PutDraftComment.java Skip migrating inline comments on missing patch set parents 2018-03-16 13:44:25 -04:00
PutMessage.java Make ChangeControl package-private 2018-02-24 12:25:41 +01:00
PutTopic.java Limit the maximum length of topic 2017-09-15 10:46:18 +02:00
Rebase.java Make ChangeControl package-private 2018-02-24 12:25:41 +01:00
RebaseChangeEdit.java Correct use of generics in AcceptsPost#post 2017-09-14 13:51:05 +02:00
RebaseChangeOp.java Discontinue draft workflow 2017-09-30 15:47:14 +02:00
RebaseUtil.java Remove ChangeResource#getControl() and migrate callers 2017-09-13 09:37:26 +02:00
Rebuild.java Format all Java files with google-java-format 2017-02-07 10:04:39 +09:00
RelatedChangesSorter.java Make ChangeControl package-private 2018-02-24 12:25:41 +01:00
Restore.java Reduce usage of ChangeControl 2017-08-29 11:05:03 +02:00
Revert.java Fix Change-Id in revert email 2018-03-15 10:07:51 +01:00
Reviewed.java Format all Java files with google-java-format 2017-02-07 10:04:39 +09:00
ReviewerJson.java Discontinue draft workflow 2017-09-30 15:47:14 +02:00
ReviewerResource.java Remove ReviewerResource#getControl() and migrate callers 2017-09-07 17:37:46 +02:00
ReviewerSuggestion.java ReviewerSuggestion: More Javadoc improvements 2018-02-07 19:17:09 +09:00
Reviewers.java Migrate accounts to NoteDb (part 2) 2017-06-27 15:56:38 +02:00
RevisionResource.java Remove ChangeResource#getControl() and migrate callers 2017-09-13 09:37:26 +02:00
RevisionReviewers.java Migrate accounts to NoteDb (part 2) 2017-06-27 15:56:38 +02:00
Revisions.java Make ChangeControl package-private 2018-02-24 12:25:41 +01:00
RobotCommentResource.java Add support for Robot Comments 2016-09-28 15:34:54 +02:00
RobotComments.java Format all Java files with google-java-format 2017-02-07 10:04:39 +09:00
SetAssigneeOp.java Hoist validation from SetAssigneeOp into PutAssignee 2017-03-29 13:18:02 +09:00
SetHashtagsOp.java Reject invalid hashtags with 400 Bad Request 2017-09-19 09:37:31 +02:00
SetPrivateOp.java Private state changed event 2017-12-19 17:36:54 +01:00
SetReadyForReview.java SetReadyForReview: Change action label to "Start Review" 2017-11-02 13:02:21 +09:00
SetWorkInProgress.java Send "comment" email when starting review 2017-06-21 11:11:27 -07:00
Submit.java Make ChangeControl package-private 2018-02-24 12:25:41 +01:00
SubmittedTogether.java Reduce usage of ChangeControl 2017-08-29 11:05:03 +02:00
SuggestChangeReviewers.java Merge "Add accounts.visibility setting to ServerInfo" 2017-09-19 07:38:33 +00:00
SuggestReviewers.java Add accounts.visibility setting to ServerInfo 2017-08-31 11:43:33 +02:00
SuggestedReviewer.java Build a Recommender for Reviewer Suggestion 2016-10-12 16:51:58 +02:00
TestSubmitRule.java Remove ChangeControl from ChangeData 2017-09-25 13:42:07 +02:00
TestSubmitType.java Remove ChangeControl from ChangeData 2017-09-25 13:42:07 +02:00
Unignore.java Remove RestApiException in Unmute and Unignore 2017-09-19 09:00:04 +02:00
VoteResource.java Allow to remove specific scores while leaving the reviewer listed 2015-11-25 11:22:56 +01:00
Votes.java ApprovalsUtil: Use ChangeNotes and CurrentUser instead of ChangeControl 2017-09-12 07:59:13 +00:00
WalkSorter.java Format all Java files with google-java-format 2017-02-07 10:04:39 +09:00
WorkInProgressOp.java WIP state changed event 2017-12-19 17:36:54 +01:00