936470ed2e
Refactored out commit validation logic from ReceiveCommits to a new CommitValidators class. Other parts of Gerrit that allow the user to create new Changes (CherryPick, Revert, Rebase) should be able to reuse selected parts of this validation code. Each separate entity of validation logic will now reside its own class, implementing the CommitValidationListener interface. While this approach will generate some more code, the maintainability should be far more sustainable, especially when we start to reuse the code in other places in Gerrit. In the future, some generalization of the error messages will probably be needed so they fit a broader scope and not only when the user is pushing the change using Git. Change-Id: I99c807742ae06571c023249f7d965b633359e7ac