94e9a699aa8311bfeea2e149de09f96d70814c89
At the moment the 'Reply' button is only highlighted if there are
draft comments on the currently viewed patch set.
Since commit 5fd7813e the 'Reply' button always publishes draft
comments on all patch sets, hence the 'Reply' button should also be
highlighted when there are draft comments on patch sets that are
currently not viewed.
To find out whether there are draft comments on the change a change
query with the 'has:draft' operator is executed. This request can be
directly answered by the secondary index. This is cheaper than using
ListChangesOption.DRAFT_COMMENTS when loading the change, since this
option results in one SQL statement per patch set to load the draft
comments from the database. In addition using
ListChangesOption.DRAFT_COMMENTS would only work when the draft
comment status is included into the ETag computation of the change,
which it is currently not and doing it would be bad for performance.
Change-Id: Ib97c09d8e7b38c0e35a068f8adebeeb409e8926c
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Description
RETIRED, Gerrit as used by OpenStack