9c6c080ca7
createdOn/lastUpdatedOn is set to the timestamp of the first/last commit on the notes branch. The initial update of the change notes must create a commit even when it is empty so that the createdOn timestamp is recorded. This initial update is done when the change is created. To reflect this is in AbstractChangeNotesTest the newChange method which creates a change is updated to also make an initial update to the change notes. As consequence of this all tests that assert timestamps must be adapted because the creation of the initial update of the change notes consumes one timestamp. Also the newUpdate method in AbstractChangeNotesTest is adapted to load the ChangeUpdate that it creates so that its revision field gets populated. Due to this tests that expected that the revision was null had to be changed as well. The multipleUpdatesIncludingComments test started to fail because the same RevWalk instance was passed two times into ChangeNotesParser. ChangeNotesParser walks the commits and for the second ChangeNotesParser instance the walk was already done. Instead of resetting the RevWalk, create a new one since this is easier to read. PostReview must take care to set the new lastUpdatedOn timestamp on the change only after the lastUpdatedOn field was populated from notedb, otherwise the lastUpdatedOn timestamp in the database will not be updated. Change-Id: I24e385e32052fc3286fab50c7377686f425baf1f Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit Code Review
Gerrit is a code review and project management tool for Git based projects.
Objective
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
Documentation
For information about how to install and use Gerrit, refer to the documentation.
Source
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Reporting bugs
Please report bugs on the issue tracker.
Contribute
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
Getting in contact
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
License
Gerrit is provided under the Apache License 2.0.
Build
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
Install binary packages (Deb/Rpm)
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.
Events
- March 14-18 2016: Gerrit Hackathon, Berlin (free seats are still available).