a4747d57a8
In I9b99490 AccountState was changed to lazily load the project watches and preferences by passing a lambda referring to the AccountConfig instance. Unfortunately, AccountConfig holds a reference to an open Repository instance. In an implementation that does not cache these instances, they are potentially expensive to hold, whether in terms of heap or open resources. Plus, they are never closed. Remove the lazy loading and go back to storing the watches and preferences directly. This may be suboptimal memory usage, but in practice will not be as bad as the many MiB of retained heap per entry we're observing on googlesource.com. We still keep the Supplier arguments in the AccountState constructor, to keep this change as simple as possible to fix a production issue; reverting I9b99490 causes many conflicts. If we want to lazily load these fields, we will need to come up with an approach that reopens the repository on demand. Alternatively, if we decide that lazy loading is not worth the effort, we should remove the Suppliers from the AccountState interface. Change-Id: Id020fd89727b0a3377a98cffe8bf2e9cc2731451
Gerrit Code Review
Gerrit is a code review and project management tool for Git based projects.
Objective
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
Documentation
For information about how to install and use Gerrit, refer to the documentation.
Source
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Reporting bugs
Please report bugs on the issue tracker.
Contribute
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
Getting in contact
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
License
Gerrit is provided under the Apache License 2.0.
Build
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
Install binary packages (Deb/Rpm)
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Use pre-built Gerrit images on Docker
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.