a7cc474cdf
Some of the tests are still using the pattern:
try {
do something that will raise an exception
} catch (ExpectedExceptionType e) {
assertEquals("Expected error message", e.getMessage());
}
The problem with this pattern is that if the expected exception is not
raised, the test still passes. This could be mitigated by adding a
call to fail() in the try-block:
try {
do something that will raise an exception
fail(); // only reached when the exception is not raised
} catch (ExpectedExceptionType e) {
assertEquals("Expected error message", e.getMessage());
}
but since we have the ExpectedException, and it's already being used in
other parts of these tests, let's use it here too:
expect(ExpectedException.class);
expectMessage("Expected error message");
do something that will raise an exception
This causes failures in the `testCopy` method of AndPredicateTest and
OrPredicateTest because the expected exceptions are not being raised.
The implementations of AndPredicate and OrPredicate were modified in
changes Id55ec1b84 and I2b8f85891 to not raise the exception, and due
to the flaw in the test pattern mentioned above, the tests continued to
pass.
Remove the now out-of-date test statements.
Change-Id: I078f4c6433a26899f7c1c7efd7b8d8f89e721da8
Gerrit Code Review
Gerrit is a code review and project management tool for Git based projects.
Objective
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
Documentation
For information about how to install and use Gerrit, refer to the documentation.
Source
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Reporting bugs
Please report bugs on the issue tracker.
Contribute
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
Getting in contact
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
License
Gerrit is provided under the Apache License 2.0.
Build
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
Install binary packages (Deb/Rpm)
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.
Events
- November 7-8 2015: Gerrit User Conference, Mountain View. (Register).
- November 9-13 2015: Gerrit Hackathon, Mountain View. (Invitation Only).
- March 2016: Gerrit Hackathon, Berlin. (Details to be confirmed).