Go to file
Shawn Pearce bc2a04d9d4 SideBySide2: Do not refocus draft box on redraw
In 44adfee8 focus was automatically transferred to any DraftBox
that was in edit mode when CodeMirror sent the onRedraw event to
the widget. Michael's intent was to auto transfer focus into a
draft after the user scrolled it out of view, and then back in.
This fails in a number of subtle ways.

If more than one draft is editable and visible the user may see focus
transfer to the wrong draft. The behavior is undefined, but probable
that focus will transfer to the draft box positioned at the highest
line number. It depends on the order CM3 fires the redraw events.

Another issue arises from using the search box:

  - create draft on a line.
  - type some text, but do not save.
  - click elsewhere in the file to focus CM3 again.
  - start search with "/".
  - type some text that matches the file.
  - focus suddenly jumps back into the draft box.

CM3 fires a redraw event somewhere during the search process,
and focus is stolen out of the search input box back into the
draft that the user just left. This is horribly confusing.

Revert the auto transfer during widget redraw.

Change-Id: I96bc1d9485b3d6cdf8d8f3d3b2f57fdea8993035
2013-12-26 17:21:28 -08:00
2013-11-28 22:56:51 -08:00
2013-11-28 22:56:51 -08:00
2013-11-30 01:53:00 -08:00
2013-11-28 22:56:51 -08:00
2013-12-12 16:25:48 +09:00
2013-11-29 10:50:59 -08:00
2013-11-29 10:50:59 -08:00
2013-11-09 07:45:00 +01:00
2008-11-14 16:59:34 -08:00
2009-03-27 20:20:10 -07:00
2013-10-17 23:09:00 +09:00
Description
RETIRED, Gerrit as used by OpenStack
120 MiB