opendev/gerrit
Code Issues Proposed changes
RETIRED, Gerrit as used by OpenStack
14,912 Commits 1 Branch 360 Tags 120 MiB
bf220b9c18
Go to file
Christian Aistleitner bf220b9c18 Escape unescaped angle brackets in javadoc 
In ab11101fb2240a15cc6fdf1e31cdd675024edc7e {@code} tags got removed
from within a few javadoc <pre> tags, arguing that they are already in
a <pre> block. But <pre> on it's own does not allow unescaped use of
angle brackets, and hence javadoc building fails [1] again on Java 8.

Re-adding {@code} would be the canonical fix, as the {@code}
tag (quoting from the javadoc man page):

  Displays text in code font without interpreting the text as HTML
  markup or nested javadoc tags.

So it allows both using angle and curly brackets within {@code}.

However, as Eclipse currently chokes on braces within {@code} and
displays warnings [2], we escape the angle brackets for now to make
both eclipse and javadoc happy.

[1]

  [...]/registration/DynamicItem.java:70: error: malformed HTML
   *   DynamicSet.itemOf(binder(), new TypeLiteral<Thing<Foo>>() {});
                                                  ^
See
  http://builds.quelltextlich.at/gerrit/nightly/master-java_8/2015-06-14/extension-api-javadoc.jar.build.stderr.txt
  http://builds.quelltextlich.at/gerrit/nightly/master-java_8/2015-06-14/index.html#extension-api-javadoc.jar

[2] See the corresponding Eclipse bugs:
  https://bugs.eclipse.org/bugs/show_bug.cgi?id=258706
  https://bugs.eclipse.org/bugs/show_bug.cgi?id=206345

Change-Id: I39b2cfd06cbc5bd5d6a46dd567ac1abf21f09ee8
2015-06-14 21:05:47 +02:00
.settings Enable Eclipse Javadoc warnings about malformed syntax 2015-06-13 12:52:20 +00:00
bucklets Rename __standalone_mode__ to STANDALONE_MODE 2014-11-24 08:44:12 +00:00
contrib Fix minor python code style issues 2014-12-18 02:51:06 +00:00
Documentation Merge changes from topic 'gitweb-cleanup' 2015-06-12 18:46:57 +00:00
gerrit-acceptance-tests Merge changes from topic 'gitweb-cleanup' 2015-06-12 18:46:57 +00:00
gerrit-antlr Kill @Rewrite support in queries 2015-05-27 03:55:33 +00:00
gerrit-cache-h2 Merge branch 'stable-2.11' 2015-04-30 11:56:32 +09:00
gerrit-common Enable Eclipse Javadoc warnings about malformed syntax 2015-06-13 12:52:20 +00:00
gerrit-extension-api Escape unescaped angle brackets in javadoc 2015-06-14 21:05:47 +02:00
gerrit-gwtdebug Organize imports 2014-12-18 11:16:03 +09:00
gerrit-gwtexpui gerrit-gwtexpui: Convert tests to use Google Truth 2015-06-04 09:49:11 +09:00
gerrit-gwtui Enable Eclipse Javadoc warnings about malformed syntax 2015-06-13 12:52:20 +00:00
gerrit-gwtui-common Remove unused parseJSON method 2015-06-04 02:41:09 +00:00
gerrit-httpd Enable Eclipse Javadoc warnings about malformed syntax 2015-06-13 12:52:20 +00:00
gerrit-launcher Replace C-style array declarations with Java-style declarations 2015-03-19 12:15:43 +09:00
gerrit-lucene Lucene: Prohibit searching empty string over a full-text field 2015-05-29 12:19:12 -07:00
gerrit-main Replace C-style array declarations with Java-style declarations 2015-03-19 12:15:43 +09:00
gerrit-oauth Merge branch 'stable-2.10' into stable-2.11 2015-05-07 10:37:48 +09:00
gerrit-openid Merge branch 'stable-2.10' into stable-2.11 2015-05-07 10:37:48 +09:00
gerrit-patch-commonsnet Replace 'for' loop with 'foreach' 2013-12-04 01:02:53 +04:00
gerrit-patch-jgit Turn on many more Eclipse warnings, and fix them 2014-10-29 15:00:17 -07:00
gerrit-pgm ErrorLogFile: Call ConsoleAppender.activateOptions() 2015-06-09 15:47:38 -07:00
gerrit-plugin-api Update version to 2.10.5 2015-06-11 15:20:35 +02:00
gerrit-plugin-archetype Update version to 2.10.5 2015-06-11 15:20:35 +02:00
gerrit-plugin-gwt-archetype Update version to 2.10.5 2015-06-11 15:20:35 +02:00
gerrit-plugin-gwtui Update version to 2.10.5 2015-06-11 15:20:35 +02:00
gerrit-plugin-js-archetype Update version to 2.10.5 2015-06-11 15:20:35 +02:00
gerrit-prettify Add missing braces around if- for- and while-statements 2015-03-19 12:15:42 +09:00
gerrit-reviewdb Declare guava and junit as exported deps of Google Truth 2015-06-04 09:41:17 +09:00
gerrit-server Enable Eclipse Javadoc warnings about malformed syntax 2015-06-13 12:52:20 +00:00
gerrit-solr IndexConfig: Configure maxLimit from Config 2015-04-23 11:30:13 -07:00
gerrit-sshd Enable Eclipse Javadoc warnings about malformed syntax 2015-06-13 12:52:20 +00:00
gerrit-util-cli Add missing braces around if- for- and while-statements 2015-03-19 12:15:42 +09:00
gerrit-util-http RequestUtilTest: Convert to use Google Truth 2015-06-04 09:41:29 +09:00
gerrit-util-ssl Turn on many more Eclipse warnings, and fix them 2014-10-29 15:00:17 -07:00
gerrit-war Update version to 2.10.5 2015-06-11 15:20:35 +02:00
lib Merge "Merge branch 'stable-2.11'" 2015-06-13 12:48:18 +00:00
plugins Merge branch 'stable-2.11' 2015-06-12 18:06:13 +09:00
ReleaseNotes Merge branch 'stable-2.11' 2015-06-12 18:06:13 +09:00
tools Buck: Disable cast checking in GWT compiler only in release mode 2015-06-05 18:47:06 +02:00
website/releases Releases: Update website to use Cloud Storage v1 API 2014-11-21 12:22:59 -08:00
.buckconfig Buck: Disable cast checking in GWT compiler only in release mode 2015-06-05 18:47:06 +02:00
.buckversion Update Buck to newest version 2015-05-10 20:03:16 +02:00
.editorconfig Add basic EditorConfig 2015-03-03 07:12:16 +00:00
.gitignore Revert "Add UNIT_TEST_GERRIT_SITE to .gitignore" 2015-04-27 14:49:03 +09:00
.gitmodules Add singleusergroup plugin 2013-11-09 07:45:00 +01:00
.mailmap Update mailmap 2015-04-08 07:50:41 +00:00
.pydevproject Update PyDev project to use Python 2.7 2014-10-02 15:16:44 +09:00
.watchmanconfig Watchman: Add buck-out dir to ignored directories 2014-08-21 07:32:37 +02:00
BUCK Buck: Disable cast checking in GWT compiler only in release mode 2015-06-05 18:47:06 +02:00
COPYING Initial project setup of Gerrit 2 2008-11-14 16:59:34 -08:00
INSTALL Remove Gerrit 1.x to 2.x import tools 2009-03-27 20:20:10 -07:00
SUBMITTING_PATCHES Update push URL in SUBMITTING_PATCHES 2012-03-29 00:57:14 -04:00
VERSION Update version to 2.10.5 2015-06-11 15:20:35 +02:00