opendev/gerrit
Code Issues Proposed changes
de3594b29e
gerrit/tools
History
David Ostrovsky d7b40c70fe Buck: Disable cast checking in GWT compiler only in release mode 
DisableCastChecking option was first added in I5dc633d5b. Since Issue
3389, that caused breakage of all Google products for many weeks, this
option is added again in the development build to prevent such severe
regressions in future.

Because the generated javascript code is bigger with cast checks, this
option is still added in release mode.

Side effect of this change is that the plugins that expose GWT module
are compiled without DisableCastChecking option in Gerrit tree mode.
Standalone bucklets driven build mode is not affected by this change.

Another side effect, that 'soyc' target for "compiler story" was
duplicated and the corresponding release mode with DisableCastChecking
is also provided with alias 'soyc_r'.

TEST PLAN:

  $ buck build gerrit

should pass only -XdisableClassMetadata option to GWT compiler. Whereas

  $ buck build release

should pass both -XdisableClassMetadata -XdisableCastChecking options.

Bug: Issue 3389
Change-Id: Ia99647357e7bff889137d4855e9c0059e6c6a4f3
2015-06-05 18:47:06 +02:00
..
eclipse Fix minor python code style issues 2014-12-18 02:51:06 +00:00
maven Buck: Simplify build rules 2015-06-05 08:07:49 +02:00
util Add a bulk query suite tester 2013-09-19 18:29:07 +00:00
__init__.py Buck: Adjust to unflattened directory structure for python libraries 2013-11-30 20:19:33 +01:00
BUCK Update Buck 2014-09-01 02:57:52 +00:00
build.defs Build Gerrit in headless mode 2015-03-04 10:59:02 +09:00
checkstyle.xml Checkstyle: Disable checks already covered by compilation warnings 2015-04-14 12:25:57 +09:00
default.defs Make sure wrong plugin manifest file is not collected from cache 2015-04-13 15:48:02 +00:00
download_all.py Fix download and download_sources to aggressively get all targets 2013-05-23 10:45:51 -07:00
download_file.py Allow to download dependencies from insecure connections 2014-07-11 12:35:44 +00:00
gerrit.importorder Update import order settings to list all top-level packages 2015-03-25 20:36:56 +00:00
git.defs Fix Eclipse project generation when plugins without tags are present 2015-04-14 17:49:21 +09:00
GoogleFormat.xml Eclipse: Bump java source and target level to 7 2013-11-29 00:15:50 +01:00
gwt-constants.defs Buck: Disable cast checking in GWT compiler only in release mode 2015-06-05 18:47:06 +02:00
java_doc.defs Allow to create javadocs for multiple packages 2014-10-22 01:28:59 +02:00
java_sources.defs Buck: Align gerrit build interface to bucklets 2014-09-09 13:20:47 +00:00
pack_war.py Fix minor python code style issues 2014-12-18 02:51:06 +00:00
plugin_archetype_deploy.sh Restrict the input of plugin_archetype_deploy.sh 2014-09-01 13:56:10 +08:00
util_test.py Buck: Support plugin own Maven repositories 2013-11-18 01:12:09 +01:00
util.py Update SSHD to 0.12.0 2014-09-11 09:48:07 +02:00
version.py version.py: Also update the VERSION file 2015-01-22 16:55:41 +09:00