opendev
/
git-review
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(1 comment)

Patch-set: 6
This commit is contained in:
Gerrit User 4146 2024-03-05 15:42:07 +00:00 committed by Gerrit Code Review
parent 4e2d794ffe
commit 6e7041acfc
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
57c61017cc1e96c2e15fb8d6011dcc944455ded7
View File

@ -16,6 +16,24 @@
"message": "\u003e Where/how was this problem observed? We merged some changes a while back to increase the Gerrit version in our tests, maybe that addressed it?\n\nGerrit didn\u0027t support java 17 until like version 3.6 or 3.7. I suspect the problem is simply due to Gerrit requiring java 11 previously. If we want to run the tests with java 17 we should update the version of gerrit tested against.",
"revId": "57c61017cc1e96c2e15fb8d6011dcc944455ded7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d90f272d_4602ed69",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 6
},
"lineNbr": 0,
"author": {
"id": 4146
},
"writtenOn": "2024-03-05T15:42:07Z",
"side": 1,
"message": "\u003e \u003e Where/how was this problem observed? We merged some changes a while back to increase the Gerrit version in our tests, maybe that addressed it?\n\u003e \n\u003e Gerrit didn\u0027t support java 17 until like version 3.6 or 3.7. I suspect the problem is simply due to Gerrit requiring java 11 previously. If we want to run the tests with java 17 we should update the version of gerrit tested against.\n\nhttps://www.gerritcodereview.com/3.6.html#release-highlights says 3.6 was the first release to support java 17. However, this doesn\u0027t work when paired with a mariadb/mysql database. I don\u0027t think this affects the git-review test setup though as that should be using h2.",
"parentUuid": "99a6e8aa_22756e40",
"revId": "57c61017cc1e96c2e15fb8d6011dcc944455ded7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}