opendev/git-review
Code Issues Proposed changes

Enabled hacking checks H305 and H307

Browse Source 
* H305  imports not grouped correctly
* H307  like imports should be grouped together

Change-Id: Ia4b376a90fed830ceea4b91caa920ff38263df5e
This commit is contained in:
Christian Berendt
2014-07-17 09:38:20 +02:00
parent ada3d9102a
commit d3b91e326e
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
git_review/cmd.py
View File

@@ -18,16 +18,17 @@ implied.
See the License for the specific language governing permissions and See the License for the specific language governing permissions and
limitations under the License.""" limitations under the License."""
import argparse
import datetime import datetime
import json import json
import os import os
import pkg_resources
import re import re
import shlex import shlex
import subprocess import subprocess
import sys import sys
import textwrap import textwrap
import pkg_resources
import requests import requests
if sys.version < '3': if sys.version < '3':
@@ -40,6 +41,7 @@ if sys.version < '3':
do_input = raw_input do_input = raw_input
else: else:
import configparser as ConfigParser import configparser as ConfigParser
import urllib.parse import urllib.parse
import urllib.request import urllib.request
urlencode = urllib.parse.urlencode urlencode = urllib.parse.urlencode
@@ -1036,8 +1038,6 @@ def convert_bool(one_or_zero):
def main(): def main():
usage = "git review [OPTIONS] ... [BRANCH]" usage = "git review [OPTIONS] ... [BRANCH]"
import argparse
class DownloadFlag(argparse.Action): class DownloadFlag(argparse.Action):
"""Additional option parsing: store value in 'dest', but """Additional option parsing: store value in 'dest', but
at the same time set one of the flag options to True at the same time set one of the flag options to True

2
tox.ini
View File

@@ -23,6 +23,6 @@ commands = python setup.py sdist {posargs}
commands = {posargs} commands = {posargs}
[flake8] [flake8]
ignore = E125,H202,H305,H307,H405,H904 ignore = E125,H202,H405,H904
show-source = True show-source = True
exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build