opendev
/
infra-manual
Code Issues Proposed changes

Cleanup Gerrit Approval event note 

The note here about how Gerrit Approval events are emitted was true for
older Gerrit. Current Gerrit (including the one we are running) emits
the event details on all events which fixes this problem for us.

Change-Id: Iedde959407c1ea214d4616f71d89468a85109a0b
This commit is contained in:
Clark Boylan 2020-03-04 11:09:45 -08:00
parent a711d9ebb3
commit d4b2082152
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
doc/source/core.rst
View File

@ -68,10 +68,3 @@ properly tracked. Note that the change will directly enter the gate
pipeline if and only if it has already a +1 vote from Zuul,
otherwise it will first enter the check pipeline like a "recheck"
would.
When re-approving, core reviewers may need to work around a specific set
of Gerrit behavior. Gerrit only emits vote values in its event stream
when a reviewer's vote values change. This means that if a core reviewer
has already voted +1 Approved in the workflow category they will need
to leave a comment of +0 in the workflow category then re-approve with
a new +1 Approved comment.