Update patch set 14
Patch Set 14: Code-Review-1 (2 comments) Patch-set: 14 Label: Code-Review=-1
This commit is contained in:
parent
882f022562
commit
f7720a9468
|
@ -0,0 +1,44 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_ad4343af",
|
||||
"filename": "manifests/install.pp",
|
||||
"patchSetId": 14
|
||||
},
|
||||
"lineNbr": 24,
|
||||
"author": {
|
||||
"id": 8482
|
||||
},
|
||||
"writtenOn": "2018-06-05T19:54:00Z",
|
||||
"side": 1,
|
||||
"message": "I don\u0027t think this installs the virtualenv package without virtualenv \u003d\u003e true, is that the intention? To avoid the conflict with one already installed from pypi?",
|
||||
"revId": "ffa648da2b46033ab3a0c1ba7459c30d8baddde4",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_6d2e8bfb",
|
||||
"filename": "manifests/install.pp",
|
||||
"patchSetId": 14
|
||||
},
|
||||
"lineNbr": 26,
|
||||
"author": {
|
||||
"id": 8482
|
||||
},
|
||||
"writtenOn": "2018-06-05T19:54:00Z",
|
||||
"side": 1,
|
||||
"message": "This shouldn\u0027t be needed, it\u0027s already included in https://github.com/voxpupuli/puppet-python/blob/1.9.4/manifests/init.pp#L94",
|
||||
"range": {
|
||||
"startLine": 26,
|
||||
"startChar": 2,
|
||||
"endLine": 26,
|
||||
"endChar": 27
|
||||
},
|
||||
"revId": "ffa648da2b46033ab3a0c1ba7459c30d8baddde4",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue