Ensure all groups are visible to all registered users.

If a group is not visible to the currently logged in user then
Gerrit will deny that user the ability to query for changes by
that group[1].  For example some users may not be able to make
the type of query specified in change Ief5408ee4774f94

Set newGroupsVisibleToAll[2] to true by default so that all
registered users can query by group.

[1] https://review-dev.openstack.org/Documentation/intro-project-owner.html#groups
[2] https://review-dev.openstack.org/Documentation/config-gerrit.html#groups

Change-Id: Iab5d72874ff620c1aca7041291bc765854fec87b

manifests/init.pp

@@ -180,6 +180,7 @@ class gerrit(
   $report_bug_text = 'Report Bug',
   $report_bug_url = '',
   $index_threads = 1,
+  $new_groups_visible_to_all = true,
 ) {
   include ::httpd
 
@@ -347,6 +348,7 @@ class gerrit(
   # - $secondary_index_type:
   # - $reindex_threads:
   # - $index_threads:
+  # - $new_groups_visible_to_all:
   file { '/home/gerrit2/review_site/etc/gerrit.config':
     ensure  => present,
     owner   => 'gerrit2',

templates/gerrit.config.erb

@@ -143,6 +143,8 @@
 	threads = <%= @index_threads %>
 <% end -%>
 <% end -%>
+[groups]
+        newGroupsVisibleToAll = <%= @new_groups_visible_to_all %>
 [mimetype "image/*"]
         safe = true
 [mimetype "text/x-yaml"]