opendev/puppet-openstack_health
Code Issues Proposed changes

Remove unnecessary beaker tests

Browse Source 
It is good enough to assume that if puppet finished successfully then it
also successfully found and installed packages and applied configs. For
the sake of maintainability, remove unnecessary tests.

Change-Id: Iac783ddacfad7a58eca08635924e04da0016b625
This commit is contained in:
Colleen Murphy 2017-06-11 21:16:13 +02:00
parent a9d0f492ba
commit ae79f7b8d4
1 changed files with 0 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
spec/acceptance/frontend_spec.rb
View File

@ -15,42 +15,6 @@ describe 'puppet-openstack_health::api manifest', :if => ['debian', 'ubuntu'].in
apply_manifest(frontend_puppet_module, catch_failures: true)
end
describe 'required packages' do
describe 'os packages' do
required_packages = [
package('apache2'),
package('nodejs'),
]
required_packages.each do |package|
describe package do
it { should be_installed }
end
end
end
describe 'npm packages' do
required_packages = [
package('node-gyp'),
package('gulp'),
]
required_packages.each do |package|
describe package do
it { should be_installed.by('npm') }
end
end
end
end
describe 'required files' do
describe file('/opt/openstack-health') do
it { should be_directory }
it { should be_owned_by 'openstack_health' }
it { should be_grouped_into 'openstack_health' }
end
end
describe 'required services' do
describe 'ports are open and services are reachable' do
describe port(80) do