opendev/puppet-storyboard
Code Issues Proposed changes

Clean up OpenStack-isms

Browse Source 
Use an IETF recommended domain name (example.org) in examples and
class parameter defaults instead of openstack.org. The only default
behavior change is for sender_email_address and the one site where
the default value would have been viable already has an override in
place to the same string anyway so this should result in no
effective behavior change.

Change-Id: I3e1bbb0bf4bfdd71f56cd429e890e90f2881bec5
This commit is contained in:
Jeremy Stanley 2018-04-18 20:36:05 +00:00
parent e5040616f3
commit ae299a57c0
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
README.md
View File

@ -89,10 +89,10 @@ will be saved, however that's not strictly necessary.
node default { node default {
class { 'storyboard::cert': class { 'storyboard::cert':
$ssl_cert_content = undef, $ssl_cert_content = undef,
$ssl_cert = '/etc/ssl/certs/storyboard.openstack.org.pem', $ssl_cert = '/etc/ssl/certs/storyboard.example.org.pem',
$ssl_key_content = undef, $ssl_key_content = undef,
$ssl_key = '/etc/ssl/private/storyboard.openstack.org.key', $ssl_key = '/etc/ssl/private/storyboard.example.org.key',
$ssl_ca_content = undef, $ssl_ca_content = undef,
$ssl_ca = '/etc/ssl/certs/ca.pem' $ssl_ca = '/etc/ssl/certs/ca.pem'

2
manifests/application.pp
View File

@ -57,7 +57,7 @@ class storyboard::application (
$enable_cron = 'True', $enable_cron = 'True',
$enable_email = 'True', $enable_email = 'True',
$sender_email_address = 'no-reply@storyboard.openstack.org', $sender_email_address = 'no-reply@storyboard.example.org',
$smtp_host = 'localhost', $smtp_host = 'localhost',
$smtp_port = 25, $smtp_port = 25,