opendev
/
subunit2sql
Code Issues Proposed changes

Fix unit using incorrect type in fake default 

This commit fixes a bug in the subunit2sql shell unit tests. The test
sets a fake default value to check it gets set properly later in the
tests. However, newer versions of oslo config do type checking and this
option was expecting a dict, not a string. This commit fixes this by
setting it the fake value to be a dict so we don't fail in oslo.config
anymore.

Change-Id: I5830cb271e5c0c20637323b52fced1483209ec96
This commit is contained in:
Matthew Treinish 2017-05-23 12:21:48 -04:00
parent 3cce87ac3b
commit 71d7811a3e
No known key found for this signature in database
GPG Key ID: FD12A0F214C9E177
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
subunit2sql/tests/test_shell.py
View File

@ -258,7 +258,7 @@ class TestProcessResults(base.TestCase):
cfg.CONF.set_override(name='artifacts', override=fake_artifacts)
fake_run_id = 'run_id'
cfg.CONF.set_override(name='run_id', override=fake_run_id)
fake_run_meta = 'run_meta'
fake_run_meta = {'run_meta': 'value'}
cfg.CONF.set_override(name='run_meta', override=fake_run_meta)
# Run process_results
shell.process_results(fake_results)