opendev/system-config
Code Issues Proposed changes

Update Mailman archive URLs to use HTTPS

Browse Source 
A missed detail of the HTTPS config migration,
/usr/lib/mailman/Mailman/Defaults.py explicitly sets this:

    PUBLIC_ARCHIVE_URL = 'http://%(hostname)s/pipermail/%(listname)s/'

Override that setting to https:// so that the archive URL embedded
in E-mail headers will no longer unnecessarily rely on our Apache
redirect. Once merged and deployed, fix_url.py will need to be rerun
for all the lists on both servers in order for this update to take
effect.

Change-Id: Ie4a6e04a2ef0de1db7336a2607059a2ad42665c2
This commit is contained in:
Jeremy Stanley 2022-07-06 13:21:17 +00:00
parent 98938a029e
commit 5a37720388
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
playbooks/roles/mailman-site/templates/mm_site_cfg.py.j2
View File

@ -58,6 +58,7 @@ MAILMAN_SITE_LIST = 'mailman'
# If you change these, you have to configure your http server # If you change these, you have to configure your http server
# accordingly (Alias and ScriptAlias directives in most httpds) # accordingly (Alias and ScriptAlias directives in most httpds)
DEFAULT_URL_PATTERN = 'https://%s/cgi-bin/mailman/' DEFAULT_URL_PATTERN = 'https://%s/cgi-bin/mailman/'
PUBLIC_ARCHIVE_URL = 'https://%(hostname)s/pipermail/%(listname)s'
PRIVATE_ARCHIVE_URL = '/cgi-bin/mailman/private' PRIVATE_ARCHIVE_URL = '/cgi-bin/mailman/private'
IMAGE_LOGOS = '/images/mailman/' IMAGE_LOGOS = '/images/mailman/'

1
playbooks/roles/mailman/templates/mm_cfg.py.j2
View File

@ -58,6 +58,7 @@ MAILMAN_SITE_LIST = 'mailman'
# If you change these, you have to configure your http server # If you change these, you have to configure your http server
# accordingly (Alias and ScriptAlias directives in most httpds) # accordingly (Alias and ScriptAlias directives in most httpds)
DEFAULT_URL_PATTERN = 'https://%s/cgi-bin/mailman/' DEFAULT_URL_PATTERN = 'https://%s/cgi-bin/mailman/'
PUBLIC_ARCHIVE_URL = 'https://%(hostname)s/pipermail/%(listname)s'
PRIVATE_ARCHIVE_URL = '/cgi-bin/mailman/private' PRIVATE_ARCHIVE_URL = '/cgi-bin/mailman/private'
IMAGE_LOGOS = '/images/mailman/' IMAGE_LOGOS = '/images/mailman/'