Update patch set 2

Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 35007 \u003c35007@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35007\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 10459 \u003c10459@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35007\u003e replied on the change"}
This commit is contained in:
Gerrit User 35007 2023-12-01 03:31:37 +00:00 committed by Gerrit Code Review
parent 4f83c888de
commit 70104398c4
1 changed files with 18 additions and 0 deletions

View File

@ -84,6 +84,24 @@
"message": "Does this affect other services too? I see share.py which follows the same pattern, but I haven\u0027t checked.\n\nWould it make sense to add unit tests?\nAnd a release note?",
"revId": "aa037e9ce093e87a7b22000c4013be247c645b71",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "54f42403_2af2e22a",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 35007
},
"writtenOn": "2023-12-01T03:31:37Z",
"side": 1,
"message": "\u003e Does this affect other services too?\n\nPossibly yes, but in our cloud we don\u0027t have `ShareService` so I did not see it as part of the story.\n\n\u003e Would it make sense to add unit tests?\n\nYes, I initially thought of adding one, but not exactly sure how can I do it easily without copy-and-pasting the test because the test is intended to test *one* possible pattern of [FAKE_URL](https://opendev.org/openinfra/python-tempestconf/src/branch/master/config_tempest/tests/services/test_compute.py#L28), do you happen to have some suggestions?\n\n\u003e And a release note?\n\nI am assuming it\u0027s for the maintainer?",
"parentUuid": "6a265ffb_e6c1d457",
"revId": "aa037e9ce093e87a7b22000c4013be247c645b71",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}