Adding some test coverage for config_generator

Change-Id: Ic27269e04deaf44221f7df26aca624bfe54db638

tests/unit/cli/test_config_generator.py

@@ -0,0 +1,53 @@
+# -*- coding:utf-8 -*-
+#
+# Copyright 2016 Hewlett-Packard Enterprise
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License. You may obtain
+# a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+
+import mock
+from stevedore import extension
+import testtools
+
+from bandit.cli import config_generator
+from bandit.core import test_properties as test
+
+
+def gen_config(name):
+    return {"test": "test data"}
+
+
+@test.takes_config('test')
+@test.checks('Str')
+def _test_plugin(context, conf):
+    pass
+
+
+class BanditConfigGeneratorTests(testtools.TestCase):
+    def _make_test_manager(self, plugin):
+        return extension.ExtensionManager.make_test_instance(
+            [extension.Extension('test', None, _test_plugin, None)])
+
+    def setUp(self):
+        mngr = self._make_test_manager(mock.MagicMock)
+        self.patchExtMan = mock.patch('stevedore.extension.ExtensionManager')
+        self.mockExtMan = self.patchExtMan.start()
+        self.mockExtMan.return_value = mngr
+        super(BanditConfigGeneratorTests, self).setUp()
+
+    def tearDown(self):
+        super(BanditConfigGeneratorTests, self).tearDown()
+        self.patchExtMan.stop()
+
+    def test_get_config_settings(self):
+        settings = config_generator.get_config_settings()
+        self.assertEqual(settings, "test: {test: test data}\n")

tests/unit/test_bandit_conf_generator.py

@@ -1,27 +0,0 @@
-# Copyright (c) 2015 VMware, Inc.
-#
-#  Licensed under the Apache License, Version 2.0 (the "License"); you may
-#  not use this file except in compliance with the License. You may obtain
-#  a copy of the License at
-#
-#       http://www.apache.org/licenses/LICENSE-2.0
-#
-#  Unless required by applicable law or agreed to in writing, software
-#  distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
-#  WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
-#  License for the specific language governing permissions and limitations
-#  under the License.
-
-import mock
-import stevedore.extension
-import testtools
-
-
-class BanditConfigGeneratorTests(testtools.TestCase):
-    @mock.patch('stevedore.extension.ExtensionManager',
-                spec=stevedore.extension.ExtensionManager)
-    @mock.patch('stevedore.extension.Extension',
-                spec=stevedore.extension.Extension)
-    def test_get_config_settings(self, ext_mgr, ext):
-        # TODO(tmcpeak): We need to add unit testing here
-        pass